public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	linux-kernel@vger.kernel.org, akpm <akpm@linux-foundation.org>,
	samr <sam@ravnborg.org>
Subject: Re: [RFC/PATCH] dontdiff: generate from gitignore
Date: Fri, 12 Sep 2008 10:41:40 -0700	[thread overview]
Message-ID: <48CAA9D4.4090000@oracle.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0809121025460.3300@nehalem.linux-foundation.org>

Linus Torvalds wrote:
> 
> On Fri, 12 Sep 2008, Randy Dunlap wrote:
>> Generate the "dontdiff" file from the .gitignore files.
> 
> t's not quite as simple as that, though.
> 
> The .gitignore files are fundamentally location hierarchy-aware, so a 
> ignore entry in one subdirectory only affects that subdirectory 
> (recursively), so if you flatten then, you should take that into account.
> 
> As far as I can tell, your script will generate lots of incorrect entries 
> due to this. Eg, it will generate
> 
> 	parse.[ch]
> 
> as a dontdiff pattern, because scripts/genksyms/.gitignore has that, but 
> that means that now it will ignore parse.c in all the _other_ places, 
> where it *isn't* a generated file (ie mm/parse.c).

Yes, that's one of the reasons that it contains "RFC" in $subject.
There's also no handling of !pattern .gitignore lines....

AFAIK, diff with a dontdiff file does not allow/support full pathname
hierarchies like .gitignore does, so this is probably a futile exercise.  ??

-- 
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

  reply	other threads:[~2008-09-12 17:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 22:09 [path] don't diff generated firmware files Arjan van de Ven
2008-09-01 23:14 ` Alexey Dobriyan
2008-09-12 17:17   ` Randy Dunlap
2008-09-12 17:17   ` [PATCH] dontdiff: more updates to be closer to gitignore Randy Dunlap
2008-09-12 17:18   ` [RFC/PATCH] dontdiff: generate from gitignore Randy Dunlap
2008-09-12 17:36     ` Linus Torvalds
2008-09-12 17:41       ` Randy Dunlap [this message]
2008-09-12 20:32         ` Kai Henningsen
     [not found] <e2e108260809130052u454b6920h9745c27eb2f4b20c@mail.gmail.com>
2008-09-14 18:23 ` [RFC PATCH] Script for generating Documentation/dontdiff from .gitignore files Eduard - Gabriel Munteanu
2008-09-15 15:34   ` Randy Dunlap
2008-09-16  3:26     ` [RFC PATCH] Script for generating Documentation/dontdiff from .gitignore files. (was Re: [RFC/PATCH] dontdiff: generate from gitignore) Eduard - Gabriel Munteanu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48CAA9D4.4090000@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox