* [PATCH] x86/paravirt: Remove duplicate paravirt_pagetable_setup_{start,done}()
@ 2008-09-03 13:36 Alex Nixon
2008-09-05 15:46 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Alex Nixon @ 2008-09-03 13:36 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Alex Nixon, Jeremy Fitzhardinge, Ingo Molnar
They were already called once in arch/x86/kernel/setup.c - we don't need to call them again.
Signed-off-by: Alex Nixon <alex.nixon@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/init_32.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
index b5c1751..113ec2f 100644
--- a/arch/x86/mm/init_32.c
+++ b/arch/x86/mm/init_32.c
@@ -460,11 +460,7 @@ static void __init pagetable_init(void)
{
pgd_t *pgd_base = swapper_pg_dir;
- paravirt_pagetable_setup_start(pgd_base);
-
permanent_kmaps_init(pgd_base);
-
- paravirt_pagetable_setup_done(pgd_base);
}
#ifdef CONFIG_ACPI_SLEEP
--
1.5.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86/paravirt: Remove duplicate paravirt_pagetable_setup_{start,done}()
2008-09-03 13:36 [PATCH] x86/paravirt: Remove duplicate paravirt_pagetable_setup_{start,done}() Alex Nixon
@ 2008-09-05 15:46 ` Ingo Molnar
2008-09-12 21:19 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2008-09-05 15:46 UTC (permalink / raw)
To: Alex Nixon; +Cc: Linux Kernel Mailing List, Jeremy Fitzhardinge
* Alex Nixon <alex.nixon@citrix.com> wrote:
> They were already called once in arch/x86/kernel/setup.c - we don't need to call them again.
>
> Signed-off-by: Alex Nixon <alex.nixon@citrix.com>
> Cc: Jeremy Fitzhardinge <jeremy@goop.org>
> Cc: Ingo Molnar <mingo@elte.hu>
applied to tip/x86/paravirt - thanks.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86/paravirt: Remove duplicate paravirt_pagetable_setup_{start,done}()
2008-09-05 15:46 ` Ingo Molnar
@ 2008-09-12 21:19 ` Jeremy Fitzhardinge
2008-09-14 16:10 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Jeremy Fitzhardinge @ 2008-09-12 21:19 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Alex Nixon, Linux Kernel Mailing List, Rafael J. Wysocki
Ingo Molnar wrote:
> * Alex Nixon <alex.nixon@citrix.com> wrote:
>
>
>> They were already called once in arch/x86/kernel/setup.c - we don't need to call them again.
>>
>> Signed-off-by: Alex Nixon <alex.nixon@citrix.com>
>> Cc: Jeremy Fitzhardinge <jeremy@goop.org>
>> Cc: Ingo Molnar <mingo@elte.hu>
>>
>
> applied to tip/x86/paravirt - thanks.
>
This fixes a regression in -rc, so it should probably go to Linus. See
http://bugzilla.kernel.org/show_bug.cgi?id=11485
J
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86/paravirt: Remove duplicate paravirt_pagetable_setup_{start,done}()
2008-09-12 21:19 ` Jeremy Fitzhardinge
@ 2008-09-14 16:10 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2008-09-14 16:10 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: Alex Nixon, Linux Kernel Mailing List, Rafael J. Wysocki
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Ingo Molnar wrote:
> > * Alex Nixon <alex.nixon@citrix.com> wrote:
> >
> >
> >> They were already called once in arch/x86/kernel/setup.c - we don't need to call them again.
> >>
> >> Signed-off-by: Alex Nixon <alex.nixon@citrix.com>
> >> Cc: Jeremy Fitzhardinge <jeremy@goop.org>
> >> Cc: Ingo Molnar <mingo@elte.hu>
> >>
> >
> > applied to tip/x86/paravirt - thanks.
> >
>
> This fixes a regression in -rc, so it should probably go to Linus. See
> http://bugzilla.kernel.org/show_bug.cgi?id=11485
ok, i've cherry-picked it over into tip/x86/urgent.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-09-14 16:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-03 13:36 [PATCH] x86/paravirt: Remove duplicate paravirt_pagetable_setup_{start,done}() Alex Nixon
2008-09-05 15:46 ` Ingo Molnar
2008-09-12 21:19 ` Jeremy Fitzhardinge
2008-09-14 16:10 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox