Re: [PATCH 1/3] [MTD] physmap.c: Check return of platform_device_register()

[Zev Weiss <zevweiss@gmail.com>]

Lennert Buytenhek wrote:
> On Fri, Sep 12, 2008 at 11:32:58PM -0700, Zev Weiss wrote:
> 
>> The PHYSMAP_COMPAT code had been ignoring the return value of
>> platform_device_register() in the physmap_init() function.
>>
>> Signed-off-by: Zev Weiss <zevweiss@gmail.com>
>> ---
>>   drivers/mtd/maps/physmap.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
>> index 42d844f..6fba0d4 100644
>> --- a/drivers/mtd/maps/physmap.c
>> +++ b/drivers/mtd/maps/physmap.c
>> @@ -312,7 +312,7 @@ static int __init physmap_init(void)
>>   	err = platform_driver_register(&physmap_flash_driver);
>>   #ifdef PHYSMAP_COMPAT
>>   	if (err == 0)
>> -		platform_device_register(&physmap_flash);
>> +		err = platform_device_register(&physmap_flash);
>>   #endif
> 
> I don't think you want the registration of the physmap driver to fail
> if the compat platform device fails to register.
> 
> One reason that the compat platform device can fail to register can be
> that there is already a non-compat platform device for the compat flash
> chip, and in that case I don't think you want to fail the driver init
> (while leaving the physmap_flash_driver registered, too!).
> 

Chalk another one up to ignorance on my part...sounds like a nak all 'round.