public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: roberto@unbit.it, jeremy@xensource.com,
	linux-kernel@vger.kernel.org, Mirko Iannella <mirko@unbit.it>,
	Alex Nixon <alex.nixon@citrix.com>
Subject: [PATCH] xen: Fix for xen guest with mem > 3.7G
Date: Sun, 14 Sep 2008 07:42:23 -0700	[thread overview]
Message-ID: <48CD22CF.9030900@goop.org> (raw)
In-Reply-To: <20080914132104.GB32106@elte.hu>

PFN_PHYS() can truncate large addresses unless its passed a suitable
large type.  This is fixed more generally in the patch series
introducing phys_addr_t, but we need a short-term fix to solve a
regression.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: roberto@unbit.it
---
 arch/x86/xen/setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

===================================================================
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -42,7 +42,7 @@
 
 	e820.nr_map = 0;
 
-	e820_add_region(0, PFN_PHYS(max_pfn), E820_RAM);
+	e820_add_region(0, PFN_PHYS((u64)max_pfn), E820_RAM);
 
 	/*
 	 * Even though this is normal, usable memory under Xen, reserve



  reply	other threads:[~2008-09-14 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-13 19:16 Fix for xen guest with mem > 3.7G Roberto De Ioris
2008-09-13 21:09 ` Jeremy Fitzhardinge
2008-09-14 13:21   ` Ingo Molnar
2008-09-14 14:42     ` Jeremy Fitzhardinge [this message]
2008-09-14 14:47       ` [PATCH] xen: " Ingo Molnar
2008-09-14 21:43       ` Roberto De Ioris
2008-09-15  6:09         ` Jeremy Fitzhardinge
2008-09-15  6:20           ` Roberto De Ioris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48CD22CF.9030900@goop.org \
    --to=jeremy@goop.org \
    --cc=alex.nixon@citrix.com \
    --cc=jeremy@xensource.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mirko@unbit.it \
    --cc=roberto@unbit.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox