From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, jbaron <jbaron@redhat.com>
Subject: Re: [PATCH] introduce boot_printk()
Date: Tue, 16 Sep 2008 11:53:36 -0700 [thread overview]
Message-ID: <48D000B0.8070108@zytor.com> (raw)
In-Reply-To: <86802c440809161137r4264190bxe76f7e6b90235087@mail.gmail.com>
Yinghai Lu wrote:
>>
>> Not only do you have duplication, here, but inconsistency...
>
> how about
> pci_printk(v, KERN_DEBUG "...\n");
>
> will put
> <pci> <7> ...\n
> in dmesg bug,
>
> and let vprintk get rid of <pci> like <7>
>
> is that what you want?
>
First of all, what is the "v" here, and why not just have
printk(KERN_PCI KERN_DEBUG "...\n");
... and we can do #define PCI_DEBUG KERN_PCI KERN_DEBUG even.
We do have a need for special macros when we're doing device-specific
prefixes, of course. If that is what your "v" is meant to be, then
there was an implicit topic shift in the discussion thread.
-hpa
next prev parent reply other threads:[~2008-09-16 18:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 8:05 [PATCH] introduce boot_printk() Yinghai Lu
2008-09-15 9:58 ` Pavel Machek
2008-09-15 16:14 ` Yinghai Lu
2008-09-15 14:54 ` Randy Dunlap
2008-09-15 17:15 ` H. Peter Anvin
2008-09-15 17:18 ` Yinghai Lu
2008-09-15 17:24 ` H. Peter Anvin
2008-09-15 17:34 ` Yinghai Lu
2008-09-16 14:26 ` Peter Zijlstra
2008-09-16 16:06 ` H. Peter Anvin
2008-09-16 16:42 ` Yinghai Lu
2008-09-16 17:44 ` Jeremy Fitzhardinge
2008-09-16 17:45 ` Yinghai Lu
2008-09-16 17:47 ` Yinghai Lu
2008-09-16 17:53 ` H. Peter Anvin
2008-09-16 18:10 ` Yinghai Lu
2008-09-16 18:15 ` H. Peter Anvin
2008-09-16 18:24 ` Yinghai Lu
2008-09-16 18:31 ` H. Peter Anvin
2008-09-16 18:37 ` Yinghai Lu
2008-09-16 18:53 ` H. Peter Anvin [this message]
2008-09-16 19:24 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D000B0.8070108@zytor.com \
--to=hpa@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox