From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754536AbYIQPIB (ORCPT ); Wed, 17 Sep 2008 11:08:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752942AbYIQPHv (ORCPT ); Wed, 17 Sep 2008 11:07:51 -0400 Received: from goliath.siemens.de ([192.35.17.28]:21361 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbYIQPHu (ORCPT ); Wed, 17 Sep 2008 11:07:50 -0400 X-Greylist: delayed 4156 seconds by postgrey-1.27 at vger.kernel.org; Wed, 17 Sep 2008 11:07:49 EDT Message-ID: <48D10E1A.8030804@siemens.com> Date: Wed, 17 Sep 2008 16:03:06 +0200 From: "Hillier, Gernot" Organization: Siemens AG, CT SE 2 User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1.9) Gecko/20070801 SUSE/2.0.0.9-0.1 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: aacraid@adaptec.com CC: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, mark_salyzyn@adaptec.com Subject: aacraid: Adaptec 2200S support broken on x86_64 by commit 94cf6ba11b068b8a8f68a1e88bffb6827e92124b Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi there! On our AMD64 machines equipped with old Adaptec 2200S controllers, we experienced a regression when updating to 2.6.25. The machines won't boot anymore (in a reasonable time), but instead spit out tons of those messages: aac_srb: aac_fib_send failed with status: 8195 This is already reported in quite some places including LKML: http://lkml.org/lkml/2008/5/12/365 https://bugzilla.redhat.com/show_bug.cgi?id=450444 https://bugzilla.redhat.com/show_bug.cgi?id=453472 http://www.linuxquestions.org/questions/red-hat-31/aacsrb-aacfibsend-failed-with-status-8195-651078/ http://forums.gentoo.org/viewtopic-p-5077382.html?sid=a51c3a0fba6aa854c0b49b8fae5cc15a We found that this regression seems to be introduced by the bugfix "aacraid: fix driver failure with Dell PowerEdge Expandable RAID Controller 3/Di": http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=94cf6ba11b068b8a8f68a1e88bffb6827e92124b By simply removing the quirk flag for our controller, we could boot again. We did some quick stress tests on an AMD64bit machine with 16GB of RAM and saw no problems after this change: diff -ur linux-2.6.25.11-0.1.ct1.orig/drivers/scsi/aacraid/linit.c linux-2.6.25.11-0.1.ct1/drivers/scsi/aacraid/linit.c --- linux-2.6.25.11-0.1.ct1.orig/drivers/scsi/aacraid/linit.c 2008-09-15 16:07:14.000000000 +0100 +++ linux-2.6.25.11-0.1.ct1/drivers/scsi/aacraid/linit.c 2008-09-15 16:09:26.000000000 +0100 @@ -176,7 +176,7 @@ { aac_rx_init, "aacraid", "ADAPTEC ", "catapult ", 2, AAC_QUIRK_31BIT | AAC_QUIRK_34SG | AAC_QUIRK_SCSI_32 }, /* catapult */ { aac_rx_init, "aacraid", "ADAPTEC ", "tomcat ", 2, AAC_QUIRK_31BIT | AAC_QUIRK_34SG | AAC_QUIRK_SCSI_32 }, /* tomcat */ { aac_rx_init, "aacraid", "ADAPTEC ", "Adaptec 2120S ", 1, AAC_QUIRK_31BIT | AAC_QUIRK_34SG | AAC_QUIRK_SCSI_32 }, /* Adaptec 2120S (Crusader) */ - { aac_rx_init, "aacraid", "ADAPTEC ", "Adaptec 2200S ", 2, AAC_QUIRK_31BIT | AAC_QUIRK_34SG | AAC_QUIRK_SCSI_32 }, /* Adaptec 2200S (Vulcan) */ + { aac_rx_init, "aacraid", "ADAPTEC ", "Adaptec 2200S ", 2, AAC_QUIRK_31BIT | AAC_QUIRK_34SG }, /* Adaptec 2200S (Vulcan) */ { aac_rx_init, "aacraid", "ADAPTEC ", "Adaptec 2200S ", 2, AAC_QUIRK_31BIT | AAC_QUIRK_34SG | AAC_QUIRK_SCSI_32 }, /* Adaptec 2200S (Vulcan-2m) */ { aac_rx_init, "aacraid", "Legend ", "Legend S220 ", 1, AAC_QUIRK_31BIT | AAC_QUIRK_34SG | AAC_QUIRK_SCSI_32 }, /* Legend S220 (Legend Crusader) */ { aac_rx_init, "aacraid", "Legend ", "Legend S230 ", 2, AAC_QUIRK_31BIT | AAC_QUIRK_34SG | AAC_QUIRK_SCSI_32 }, /* Legend S230 (Legend Vulcan) */ Can this be safely changed/merged? Or is this the wrong way to fix it? Please note that we also have machines equipped with newer Adaptec 2230S controllers (PCI ID 9005:0286) which run perfectly with the current driver. -- Kind regards, Gernot Hillier Siemens AG, CT SE 2, Corporate Competence Center Embedded Linux