Re: [PATCH] Fix declaration of cgroup_mm_owner_callbacks

Balbir Singh
2008-09-17T21:30:43Z

Andrew Morton wrote:
> On Mon, 15 Sep 2008 12:06:38 -0700 (PDT)
> menage@google.com (Paul Menage) wrote:
>
>> Fix declaration of cgroup_mm_owner_callbacks()
>>
>> The choice of real/dummy declaration for cgroup_mm_owner_callbacks()
>> shouldn't be based on CONFIG_MM_OWNER, but on
>> CONFIG_CGROUPS. Otherwise kernel/exit.c fails to compile when
>> something other than a cgroups controller selects CONFIG_MM_OWNER
>>
>
> Being too lazy to go back and find out what "something" is, I assumed
> that this isn't needed in 2.6.27.

We don't have anything using CONFIG_MM_OWNER in 2.6.27, so we should be OK
pushing this to 2.6.28 (Pekka plans to use it for revoke* calls).

Pekka, Paul do you agree?

--
Balbir