From: Pekka Enberg <penberg@cs.helsinki.fi>
To: balbir@linux.vnet.ibm.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <menage@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix declaration of cgroup_mm_owner_callbacks
Date: Thu, 18 Sep 2008 00:39:35 +0300 [thread overview]
Message-ID: <48D17917.5080700@cs.helsinki.fi> (raw)
In-Reply-To: <48D176EA.9040304@linux.vnet.ibm.com>
Balbir Singh wrote:
> Andrew Morton wrote:
>> On Mon, 15 Sep 2008 12:06:38 -0700 (PDT)
>> menage@google.com (Paul Menage) wrote:
>>
>>> Fix declaration of cgroup_mm_owner_callbacks()
>>>
>>> The choice of real/dummy declaration for cgroup_mm_owner_callbacks()
>>> shouldn't be based on CONFIG_MM_OWNER, but on
>>> CONFIG_CGROUPS. Otherwise kernel/exit.c fails to compile when
>>> something other than a cgroups controller selects CONFIG_MM_OWNER
>>>
>> Being too lazy to go back and find out what "something" is, I assumed
>> that this isn't needed in 2.6.27.
>
> We don't have anything using CONFIG_MM_OWNER in 2.6.27, so we should be OK
> pushing this to 2.6.28 (Pekka plans to use it for revoke* calls).
Oh, I am already using it:
http://git.kernel.org/?p=linux/kernel/git/penberg/linux-2.6.git;a=commitdiff;h=3201a05704afafd7c61b204b7f0c2a9ddcf935d0
Still debugging some ext3 corruption problems, though :-)
> Pekka, Paul do you agree?
Yes, agreed.
next prev parent reply other threads:[~2008-09-17 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 19:06 [PATCH] Fix declaration of cgroup_mm_owner_callbacks Paul Menage
2008-09-15 19:10 ` Pekka Enberg
2008-09-17 21:27 ` Andrew Morton
2008-09-17 21:24 ` Pekka Enberg
2008-09-17 21:30 ` Balbir Singh
2008-09-17 21:39 ` Pekka Enberg [this message]
2008-09-17 23:36 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D17917.5080700@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox