From: "H. Peter Anvin" <hpa@zytor.com>
To: Jason Baron <jbaron@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] loglevel=pci:8,acpi:8,apic=8 support v6
Date: Thu, 18 Sep 2008 08:57:50 -0700 [thread overview]
Message-ID: <48D27A7E.8090403@zytor.com> (raw)
In-Reply-To: <20080918155041.GB3097@redhat.com>
Jason Baron wrote:
>
> if we take this argument to its extreme, then we end up spending all of
> our time verifying that the kernel is working correctly and no time
> actually doing work. I think 'printk_ratelimit' captures this. Thus, the line
> has to be drawn somewhere. If you want the messages in 'dmesg' use,
> printk(KERN_DEBUG), and 'grep'. For the rest, I propose pre-filtering, which is
> what 'dynamic debug' uses.
>
Taking any argument to its extreme and you come up with something
ridiculous.
One could equally argue that if you have so many debugging messages that
you have to prefilter for performance, you're so bloating your kernel
that you need to stop.
I find it highly questionable that it makes sense to put even skipped
messages into hot paths in the production kernel. Skipped prints are
NOT free, even if they are lot cheaper than actually rendering the string.
-hpa
next prev parent reply other threads:[~2008-09-18 15:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 8:27 [PATCH 0/6] loglevel=pci:8,acpi:8,apic=8 support v6 Yinghai Lu
2008-09-17 8:27 ` [PATCH 1/6] add DEFINE_LOGLEVEL_SETUP v7 Yinghai Lu
2008-09-17 8:27 ` [PATCH 2/6] pci: add KERN_PCI Yinghai Lu
2008-09-17 8:27 ` [PATCH 3/6] pci: using printk(KERN_PCI v3 Yinghai Lu
2008-09-17 8:35 ` Ingo Molnar
2008-09-17 8:41 ` Yinghai Lu
2008-09-17 10:11 ` Robert Richter
2008-09-17 16:25 ` Yinghai Lu
2008-09-17 22:28 ` Bjorn Helgaas
2008-09-17 23:03 ` Yinghai Lu
2008-09-17 8:27 ` [PATCH 4/6] acpi: add KERN_ACPI v3 Yinghai Lu
2008-09-17 8:27 ` [PATCH 5/6] apci: dump slit with printk(KERN_ACPI...) Yinghai Lu
2008-09-17 18:19 ` Marcin Slusarz
2008-09-17 18:28 ` Yinghai Lu
2008-09-17 18:56 ` Marcin Slusarz
2008-09-17 8:27 ` [PATCH 6/6] x86: add KERN_APIC Yinghai Lu
2008-09-17 8:38 ` Ingo Molnar
2008-09-17 8:45 ` Yinghai Lu
2008-09-17 8:52 ` Ingo Molnar
2008-09-17 12:08 ` Frans Pop
2008-09-17 16:30 ` Yinghai Lu
2008-09-17 8:55 ` [PATCH 0/6] loglevel=pci:8,acpi:8,apic=8 support v6 Andrew Morton
2008-09-17 9:27 ` Ingo Molnar
2008-09-17 18:46 ` Jason Baron
2008-09-17 19:25 ` H. Peter Anvin
2008-09-18 10:57 ` Ingo Molnar
2008-09-18 15:36 ` H. Peter Anvin
2008-09-18 15:50 ` Jason Baron
2008-09-18 15:57 ` H. Peter Anvin [this message]
2008-09-18 16:19 ` Jason Baron
2008-09-18 18:39 ` H. Peter Anvin
2008-09-18 19:06 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D27A7E.8090403@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox