From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753872AbYISNEQ (ORCPT ); Fri, 19 Sep 2008 09:04:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751503AbYISNEF (ORCPT ); Fri, 19 Sep 2008 09:04:05 -0400 Received: from outbound-wa4.frontbridge.com ([216.32.181.16]:4553 "EHLO WA4EHSOBE004.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbYISNED (ORCPT ); Fri, 19 Sep 2008 09:04:03 -0400 X-BigFish: VPS-9(zz1432R98dR936eQ1805M9320imzz10d3izzz32i6bh43j61h) X-Spam-TCS-SCL: 0:0 X-FB-SS: 5, X-WSS-ID: 0K7G1ME-01-AMR-01 Message-ID: <48D3A338.5070400@amd.com> Date: Fri, 19 Sep 2008 15:03:52 +0200 From: Peter Oruba Organization: AMD (OSRC) User-Agent: Thunderbird 2.0.0.16 (X11/20080720) MIME-Version: 1.0 To: "Giacomo A. Catenazzi" CC: Dmitry Adamushko , Arjan van de Ven , Ingo Molnar , Thomas Gleixner , Tigran Aivazian , LKML Subject: Re: [patch 05/11] [PATCH 05/11] x86: Moved microcode.c to microcode_intel.c. References: <20080728164411.490752571@amd.com> <20080728164448.492961653@amd.com> <20080907120823.59f8fa47@infradead.org> <48CA586C.2010104@amd.com> <20080912063517.783b7f85@infradead.org> <48D3942B.1050901@amd.com> <48D3A1FD.7010309@debian.org> In-Reply-To: <48D3A1FD.7010309@debian.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 19 Sep 2008 13:03:53.0073 (UTC) FILETIME=[2A96A610:01C91A58] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Giacomo A. Catenazzi schrieb: > Dmitry Adamushko wrote: >> 2008/9/19 Peter Oruba : >>> Some additonal words regarding the current user space issues: >>> >>> IMHO the most convenient way to update microcode is through the >>> firmware loading >>> interface instead of microcode_ctl. This reduces user-space >>> responsibilities to >>> loading the correct module at boot time and to place the microcode >>> patch file at >>> the right location via package installation. The problems mentioned >>> in this >>> thread would then probably disappear as well. What do you guys think? >> >> It'd still require changes for all the setups that currently rely on >> the 'microcode_ctl' interface. Moreover, Arjan's setup failed not due >> to the 'microcode_ctl' per se but due to the altered kernel module >> name. After all, we can't break the established interface this way. >> >> We can either reserve 'microcode' as a legacy name for intel cpus (== >> microcode_intel), or maybe we can use request_module() from >> microcode.ko to load a proper arch-specific module (I guess, it's not >> ok for !KMOD-enabled kernels). > > I agree. A wrapper "microcode.ko" module would be nice, in order > to allow independent kernel and user space upgrades. > > The module name is important also on udev method: only a module > load triggers the microcode request in udev, thus also the > new method should have stable kernel module name. > > ciao > cate > That sounds like a single-module solution would be the best way to go. All dependencies would then be handled inside the module. -Peter