From: Anti Sullin <anti.sullin@artecdesign.ee>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Victor <linux@maxim.org.za>
Subject: Re: [PATCH] atmel_serial: update the powersave handler to match serial core
Date: Fri, 19 Sep 2008 18:19:53 +0300 [thread overview]
Message-ID: <48D3C319.4040605@artecdesign.ee> (raw)
In-Reply-To: <1221837111-20107-1-git-send-email-haavard.skinnemoen@atmel.com>
One more bug of mine...
Haavard Skinnemoen wrote:
> }
> @@ -1491,11 +1498,9 @@ static int atmel_serial_resume(struct platform_device *pdev)
> struct uart_port *port = platform_get_drvdata(pdev);
> struct atmel_uart_port *atmel_port = to_atmel_uart_port(port);
>
> - if (atmel_port->suspended) {
> - uart_resume_port(&atmel_uart, port);
> - atmel_port->suspended = 0;
> - } else
> - disable_irq_wake(port->irq);
> + device_set_wakeup_enable(&pdev->dev, atmel_port->may_wakeup);
> +
> + uart_resume_port(&atmel_uart, port);
Just now noticed - these two lines should be switched.
>
> return 0;
> }
--
Anti Sullin
Embedded Software Engineer
Artec Design LLC
Akadeemia tee 23A, 12618, Tallinn, Estonia
http://www.artecdesign.ee
next prev parent reply other threads:[~2008-09-19 15:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 15:11 [PATCH] atmel_serial: update the powersave handler to match serial core Haavard Skinnemoen
2008-09-19 15:19 ` Anti Sullin [this message]
2008-09-19 15:39 ` [PATCH v2] " Haavard Skinnemoen
-- strict thread matches above, loose matches on Subject: below --
2008-09-19 15:33 [PATCH] " Michael Trimarchi
2008-09-19 15:46 ` Haavard Skinnemoen
2008-09-19 16:01 Michael Trimarchi
2008-09-19 16:15 ` Haavard Skinnemoen
2008-09-19 16:33 Michael Trimarchi
2008-09-19 18:35 ` Haavard Skinnemoen
2008-09-19 21:49 ` Anti Sullin
2008-09-20 13:01 ` Haavard Skinnemoen
2008-09-20 9:31 Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D3C319.4040605@artecdesign.ee \
--to=anti.sullin@artecdesign.ee \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@maxim.org.za \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox