public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Peterson <joe@skyrush.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	hpa@zytor.com
Subject: Re: [PATCH] Fix backspace on wrapped lines in console (virtual terminal)
Date: Sat, 20 Sep 2008 10:48:11 -0600	[thread overview]
Message-ID: <48D5294B.2010804@skyrush.com> (raw)
In-Reply-To: <20080920173822.51794923@lxorguk.ukuu.org.uk>

Alan Cox wrote:
> On Sat, 20 Sep 2008 10:25:49 -0600
> Joe Peterson <joe@skyrush.com> wrote:
> 
>> Attached is a patch that fixes virtual terminal problems when backspace
>> is used on wrapped lines (see patch text for the specific issues).  The
>> issues can be demonstrated by trying two things in the console (vt):
> 
> I would need to power up my vt420 to check (yes I have one lurking in a
> corner!) but I have a feeling the current behaviour (not going up a line)
> is correct for ansi type terminals.

Would it still erase the actual characters input, though?  This would
cause one to believe they were not erased, since the visual feedback
does not match...  I wonder if "fixing" this in Linux would really break
the needed vt hardware compatibility - maybe that case lies in the
"undefined" area in a sense.

What about the need_wrap (end of line) case - I wonder what the real
vt420 does for that.  If it doesn't match the behavior this patch
"fixes", it would probably be a vt420 bug...

Yes, these things are certainly getting harder to check against real
hardware these days!  :)

						-Joe

  reply	other threads:[~2008-09-20 16:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-20 16:25 [PATCH] Fix backspace on wrapped lines in console (virtual terminal) Joe Peterson
2008-09-20 16:38 ` Alan Cox
2008-09-20 16:48   ` Joe Peterson [this message]
2008-09-20 23:51   ` Joe Peterson
2008-09-21 16:14     ` Joe Peterson
2008-09-23 20:39       ` Joe Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D5294B.2010804@skyrush.com \
    --to=joe@skyrush.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox