From: "Giacomo A. Catenazzi" <cate@cateee.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: Chris Li <lkml@chrisli.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: diet-kconfig: a script to trim unneeded kconfigs
Date: Mon, 22 Sep 2008 15:39:09 +0200 [thread overview]
Message-ID: <48D79FFD.1060102@cateee.net> (raw)
In-Reply-To: <s5hk5d4xzw0.wl%tiwai@suse.de>
Takashi Iwai wrote:
> At Fri, 19 Sep 2008 16:55:51 -0700,
> Chris Li wrote:
>
>> I avoid arch/ and firmware/ because it is nasty. I figure module in
>> arch/ is small enough I don't mind building it. And the firmware directory,
>> if I don't build the module loads it. Those firmware will automatically skipped
>> any way.
>
> Agreed.
>
>> The little tricky part is some thing like this:
>> ========================
>> ifeq ($(CONFIG_BLK_DEV_CMD640), m)
>> obj-m += cmd640.o
>> endif
>> ========================
>> Internally it get convert it into:
>> "obj-$(CONFIG_BLK_DEV_CMD640) += cmd640.o"
Are you sure?
I.e. if you set CONFIG_BLK_DEV_CMD640=y, you see that
the two constructs gives different results.
If the makefile author did such complex construct, I
really think there is a reason ;-)
ciao
cate
>
> This should be fixed in Makefile.
> Care to submit a patch?
>
>
> Takashi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2008-09-22 13:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 23:55 diet-kconfig: a script to trim unneeded kconfigs Takashi Iwai
2008-09-18 14:01 ` Giacomo A. Catenazzi
2008-09-18 20:09 ` Takashi Iwai
2008-09-18 15:25 ` Mauro Carvalho Chehab
2008-09-18 15:43 ` Giacomo A. Catenazzi
2008-09-18 16:27 ` Mauro Carvalho Chehab
2008-09-19 9:12 ` Giacomo A. Catenazzi
2008-09-19 16:01 ` Takashi Iwai
2008-09-19 23:55 ` Chris Li
2008-09-19 23:57 ` Chris Li
2008-09-22 10:01 ` Takashi Iwai
2008-09-22 13:39 ` Giacomo A. Catenazzi [this message]
2008-09-22 15:41 ` Steven Rostedt
2008-09-22 15:50 ` Takashi Iwai
2008-09-22 19:25 ` Chris Li
2008-09-23 11:31 ` Takashi Iwai
2008-09-23 18:15 ` Chris Li
2008-09-23 18:50 ` Takashi Iwai
2008-09-23 19:40 ` Chris Li
2008-09-18 20:20 ` Takashi Iwai
2008-09-18 20:17 ` Takashi Iwai
2008-09-18 21:09 ` Valdis.Kletnieks
2008-09-18 22:14 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D79FFD.1060102@cateee.net \
--to=cate@cateee.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@chrisli.org \
--cc=mchehab@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox