From: Henrik Rydberg <rydberg@euromail.se>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: nicolas@boichat.ch, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: applesmc: Add support for Macbook Pro 3
Date: Tue, 23 Sep 2008 23:34:54 +0200 [thread overview]
Message-ID: <48D960FE.7000409@euromail.se> (raw)
In-Reply-To: <20080923133539.0146d940.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Tue, 23 Sep 2008 19:30:27 +0200
> Henrik Rydberg <rydberg@euromail.se> wrote:
>
>> This patch adds temperature sensor support for Macbook Pro 3.
>
> For some reason I keep on having to fix rejects in
> applesmc_whitelist[].
>
I have also experienced that problem. Odd. Please see my comment below.
Thanks,
Henrik
-----
> Here's what I now have:
>
> /* Note that DMI_MATCH(...,"MacBook") will match "MacBookPro1,1".
> * So we need to put "Apple MacBook Pro" before "Apple MacBook". */
> static __initdata struct dmi_system_id applesmc_whitelist[] = {
> { applesmc_dmi_match, "Apple MacBook Air", {
> DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir") },
> &applesmc_dmi_data[7]},
> { applesmc_dmi_match, "Apple MacBook Pro 4", {
> DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro4") },
> &applesmc_dmi_data[8]},
> { applesmc_dmi_match, "Apple MacBook Pro 3", {
> DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro3") },
> &applesmc_dmi_data[9]},
The two entries above are in reversed order in my tree, but
as you say, it does not matter.
> { applesmc_dmi_match, "Apple MacBook Pro", {
> DMI_MATCH(DMI_BOARD_VENDOR,"Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME,"MacBookPro") },
> &applesmc_dmi_data[0]},
> { applesmc_dmi_match, "Apple MacBook (v2)", {
> DMI_MATCH(DMI_BOARD_VENDOR,"Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME,"MacBook2") },
> &applesmc_dmi_data[1]},
> { applesmc_dmi_match, "Apple MacBook (v3)", {
> DMI_MATCH(DMI_BOARD_VENDOR,"Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME,"MacBook3") },
> &applesmc_dmi_data[6]},
> { applesmc_dmi_match, "Apple MacBook", {
> DMI_MATCH(DMI_BOARD_VENDOR,"Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME,"MacBook") },
> &applesmc_dmi_data[2]},
> { applesmc_dmi_match, "Apple Macmini", {
> DMI_MATCH(DMI_BOARD_VENDOR,"Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME,"Macmini") },
> &applesmc_dmi_data[3]},
> { applesmc_dmi_match, "Apple MacPro2", {
> DMI_MATCH(DMI_BOARD_VENDOR,"Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME,"MacPro2") },
> &applesmc_dmi_data[4]},
> { applesmc_dmi_match, "Apple iMac", {
> DMI_MATCH(DMI_BOARD_VENDOR,"Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME,"iMac") },
> &applesmc_dmi_data[5]},
> { .ident = NULL }
> };
>
> From my reading, we're still OK wrt the prefix-based string matching.
> But please do double-chck this.
>
prev parent reply other threads:[~2008-09-23 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 17:30 [PATCH] hwmon: applesmc: Add support for Macbook Pro 3 Henrik Rydberg
2008-09-23 20:35 ` Andrew Morton
2008-09-23 21:34 ` Henrik Rydberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D960FE.7000409@euromail.se \
--to=rydberg@euromail.se \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=nicolas@boichat.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox