From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755096AbYIWVf7 (ORCPT ); Tue, 23 Sep 2008 17:35:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751535AbYIWVfu (ORCPT ); Tue, 23 Sep 2008 17:35:50 -0400 Received: from h155.mvista.com ([63.81.120.155]:46682 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751124AbYIWVft (ORCPT ); Tue, 23 Sep 2008 17:35:49 -0400 Message-ID: <48D9612D.7060601@ru.mvista.com> Date: Wed, 24 Sep 2008 01:35:41 +0400 From: Sergei Shtylyov User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: avorontsov@ru.mvista.com Cc: Andrew Morton , dbrownell@users.sourceforge.net, greg@kroah.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, leoli@freescale.com, timur@freescale.com Subject: Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller References: <20080918151659.GA20140@oksana.dev.rtsoft.ru> <20080918151746.GC31187@oksana.dev.rtsoft.ru> <20080919162324.e354ed2f.akpm@linux-foundation.org> <20080923183129.GA19024@oksana.dev.rtsoft.ru> <48D96052.6090005@ru.mvista.com> In-Reply-To: <48D96052.6090005@ru.mvista.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, I wrote: >>>> This patch adds support for the FHCI USB controller, as found >>>> in the Freescale MPC836x and MPC832x processors. It can support >>>> Full or Low speed modes. Ah, it's not even high-speed? >>>> Quite a lot the hardware is doing by itself (SOF generation, CRC >>>> generation and checking), though scheduling and retransmission is on >>>> software's shoulders. I imagine that must be worse than MUSB... :-/ >>>> This controller does not integrate the root hub, so this driver also >>>> fakes one-port hub. External hub is required to support more than >>>> one device. >>>> >>>> ... >>>> >>>> >>> Please, no. >>> >> >> What exactly 'no'? ;-) >> > > No one-port hubs I guess -- they are pointless. Though e.g. MUSB > driver creates one -- I guess to impersonate a transaction translating > high-speed hub... > ... then the root hub emulation is completely pointless. WBR, Sergei