From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1753634AbYIWVje@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753634AbYIWVje (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Sep 2008 17:39:34 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755884AbYIWVjY
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 23 Sep 2008 17:39:24 -0400
Received: from terminus.zytor.com ([198.137.202.10]:58467 "EHLO
	terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755868AbYIWVjX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Sep 2008 17:39:23 -0400
Message-ID: <48D961B7.7030408@zytor.com>
Date: Tue, 23 Sep 2008 14:37:59 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: Alain Knaff <alain@knaff.lu>
CC: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, w@1wt.eu
Subject: Re: [update5] [PATCH] init: bzip2 or lzma -compressed kernels and
 initrds
References: <200809090641.m896fscX028849@hitchhiker.org.lu> <48C99F29.2030007@zytor.com> <48C9A6C0.4070802@knaff.lu> <48C9A80D.1010703@zytor.com> <48D73858.3070900@knaff.lu> <48D7C304.4020709@zytor.com> <48D7C48F.8010907@knaff.lu> <48D93E68.6040701@zytor.com> <48D9471E.9090108@knaff.lu> <48D95A8F.10705@zytor.com> <48D95ECC.9010107@knaff.lu>
In-Reply-To: <48D95ECC.9010107@knaff.lu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alain Knaff wrote:
> H. Peter Anvin wrote:
>> More failures...
>>
>> /bin/sh: scripts/bin_size: No such file or directory
> 
> Could be a permission issue. Did you try to chmod 755 scripts/bin_size ?
> Hmmm, diff does indeed not encode permissions, how should such cases be
> usually handled?
> 

A few more thoughts:

quiet_cmd_bzip2 = BZIP2    $@
cmd_bzip2 = (bzip2 -9 < $< ; $(size_append) $<) > $@

quiet_cmd_lzma = LZMA    $@
cmd_lzma = (lzma -9 -c $< ; $(size_append) $<) >$@

These will produce stale files on failure.  Using stdout in Makefiles is 
a bit tricky.  You probably need something like:

(bzip2 -9 < $<  && $(size_append) $<) > $@ || (rm -f $@ ; false)

	-hpa