public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] block: installing include/linux/blktrace_api.h
@ 2008-09-24 14:42 John Jolly
  0 siblings, 0 replies; 4+ messages in thread
From: John Jolly @ 2008-09-24 14:42 UTC (permalink / raw)
  To: axboe; +Cc: Jan Blunck, linux-kernel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

From: John Jolly <jjolly@novell.com>

Added line to install include/linux/blktrace_api.h during 'make headers_install'

Signed-off-by: John Jolly <jjolly@novell.com>
CC: Jan Blunck <JBlunck@novell.com>
- ---
 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index b68ec09..f1e5fa1 100644
- --- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -41,6 +41,7 @@ header-y += baycom.h
 header-y += bfs_fs.h
 header-y += blkpg.h
 header-y += bpqether.h
+header-y += blktrace_api.h
 header-y += can.h
 header-y += cdk.h
 header-y += chio.h
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkjaUeoACgkQdLWlL2z7PiVIogCgtT+z9KQOhY5eza8EoU/O0hKp
XG4AnROtNWlScQA+em7tVxuA9H+22/6Q
=b3Pe
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] block: installing include/linux/blktrace_api.h
@ 2008-09-24 14:47 John Jolly
  2008-10-02  6:11 ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: John Jolly @ 2008-09-24 14:47 UTC (permalink / raw)
  To: axboe; +Cc: Jan Blunck, linux-kernel

From: John Jolly <jjolly@novell.com>

Added line to install include/linux/blktrace_api.h during 'make headers_install'

Signed-off-by: John Jolly <jjolly@novell.com>
CC: Jan Blunck <JBlunck@novell.com>
---
 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index b68ec09..f1e5fa1 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -41,6 +41,7 @@ header-y += baycom.h
 header-y += bfs_fs.h
 header-y += blkpg.h
 header-y += bpqether.h
+header-y += blktrace_api.h
 header-y += can.h
 header-y += cdk.h
 header-y += chio.h

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] block: installing include/linux/blktrace_api.h
  2008-09-24 14:47 John Jolly
@ 2008-10-02  6:11 ` Andrew Morton
  2008-10-02  6:38   ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-10-02  6:11 UTC (permalink / raw)
  To: John Jolly; +Cc: axboe, JBlunck, linux-kernel

> On Wed, 24 Sep 2008 08:47:51 -0600 John Jolly <jjolly@novell.com> wrote:
> From: John Jolly <jjolly@novell.com>
> 
> Added line to install include/linux/blktrace_api.h during 'make headers_install'
> 
> Signed-off-by: John Jolly <jjolly@novell.com>
> CC: Jan Blunck <JBlunck@novell.com>
> ---
>  include/linux/Kbuild |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index b68ec09..f1e5fa1 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -41,6 +41,7 @@ header-y += baycom.h
>  header-y += bfs_fs.h
>  header-y += blkpg.h
>  header-y += bpqether.h
> +header-y += blktrace_api.h
>  header-y += can.h
>  header-y += cdk.h
>  header-y += chio.h

The two basic and almost always necessary parts of a patch changelog are

a) what was changed and

b) why the change was made

Your changelog had no b), hence nobody is likely to apply the patch.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] block: installing include/linux/blktrace_api.h
  2008-10-02  6:11 ` Andrew Morton
@ 2008-10-02  6:38   ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2008-10-02  6:38 UTC (permalink / raw)
  To: Andrew Morton; +Cc: John Jolly, JBlunck, linux-kernel

On Wed, Oct 01 2008, Andrew Morton wrote:
> > On Wed, 24 Sep 2008 08:47:51 -0600 John Jolly <jjolly@novell.com> wrote:
> > From: John Jolly <jjolly@novell.com>
> > 
> > Added line to install include/linux/blktrace_api.h during 'make headers_install'
> > 
> > Signed-off-by: John Jolly <jjolly@novell.com>
> > CC: Jan Blunck <JBlunck@novell.com>
> > ---
> >  include/linux/Kbuild |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> > index b68ec09..f1e5fa1 100644
> > --- a/include/linux/Kbuild
> > +++ b/include/linux/Kbuild
> > @@ -41,6 +41,7 @@ header-y += baycom.h
> >  header-y += bfs_fs.h
> >  header-y += blkpg.h
> >  header-y += bpqether.h
> > +header-y += blktrace_api.h
> >  header-y += can.h
> >  header-y += cdk.h
> >  header-y += chio.h
> 
> The two basic and almost always necessary parts of a patch changelog are
> 
> a) what was changed and
> 
> b) why the change was made
> 
> Your changelog had no b), hence nobody is likely to apply the patch.

A similar patch is already merged for 2.6.28 as well.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-10-02  6:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-24 14:42 [PATCH 1/1] block: installing include/linux/blktrace_api.h John Jolly
  -- strict thread matches above, loose matches on Subject: below --
2008-09-24 14:47 John Jolly
2008-10-02  6:11 ` Andrew Morton
2008-10-02  6:38   ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox