From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbYIYBaO (ORCPT ); Wed, 24 Sep 2008 21:30:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751371AbYIYB36 (ORCPT ); Wed, 24 Sep 2008 21:29:58 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:52670 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbYIYB35 (ORCPT ); Wed, 24 Sep 2008 21:29:57 -0400 Message-ID: <48DAE98D.3070208@garzik.org> Date: Wed, 24 Sep 2008 21:29:49 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Jiri Kosina CC: Jeff Kirsher , Ingo Molnar , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jesse.brandeburg@intel.com, john.ronciak@intel.com, Bruce Allan Subject: Re: [PATCH 3/3] e1000e: remove failed request for sw/fw/hw flag References: <20080923224630.6927.28967.stgit@jtkirshe-mobile.jf.intel.com> <48DAE089.20307@garzik.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Kosina wrote: > On Wed, 24 Sep 2008, Jeff Garzik wrote: > >>> When the driver fails to acquire the control flag used to serialize >>> NVM and PHY accesses between the driver, firmware and hardware, remove the >>> request for the flag otherwise the hardware might grant the flag when it >>> becomes available but the driver will not release the flag. This could >>> cause the firmware to prevent the driver getting the flag for all future >>> attempts. >> applied > > BTW are you going to take the whole series, or just this fix? Just this fix Jeff