Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

Timur Tabi
2008-09-25T13:55:23Z

Li Yang wrote:

>> -subsys_initcall(of_fsl_dma_chan_init);
>> subsys_initcall(of_fsl_dma_init);
>
> Not a critical problem. But module_init() are preferred for modules.

This was intentional. When compiled as a module, subsys_initcall becomes
module_init(). When compiled in-kernel, this code is initialized before most
drivers, so it's ready when the drivers are loaded.

> Acked-by: Li Yang <leoli@freescale.com>

Thanks.

--
Timur Tabi
Linux kernel developer at Freescale