From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754878AbYIYUzc (ORCPT ); Thu, 25 Sep 2008 16:55:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753342AbYIYUzY (ORCPT ); Thu, 25 Sep 2008 16:55:24 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:55661 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503AbYIYUzY (ORCPT ); Thu, 25 Sep 2008 16:55:24 -0400 Message-ID: <48DBFAB5.2010709@garzik.org> Date: Thu, 25 Sep 2008 16:55:17 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Chris Snook CC: Kevin Hao , Jeff Garzik , Jay Cliburn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: remove LLTX in atl2 driver References: <1222302922-13200-1-git-send-email-kexin.hao@windriver.com> <48DBF4DD.8060908@redhat.com> In-Reply-To: <48DBF4DD.8060908@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris Snook wrote: > Kevin Hao wrote: >> When NETIF_F_LLTX is set, the atlx driver will use a private lock. >> But in recent kernels this implementation seems redundant and >> can cause problems where AF_PACKET sees things twice. Since >> NETIF_F_LLTX is marked as deprecated and shouldn't be used in >> new driver, this patch removes NETIF_F_LLTX and adds a mmiowb >> before sending packet. >> >> Signed-off-by: Kevin Hao > > Can you explain a bit more concretely the problem this solves, and your > testing? Ultimately we'll want to merge this code with the atl1 code, > so we need to be confident that we can and should make the same change > there. > > -- Chris > >> --- >> drivers/net/atlx/atl2.c | 24 +----------------------- >> drivers/net/atlx/atl2.h | 1 - >> 2 files changed, 1 insertions(+), 24 deletions(-) Not directly addressing your question, but LLTX is indeed deprecated and in general we want to move away from it. Jeff