From: Arjan van de Ven <arjan@linux.intel.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Suresh Siddha <suresh.b.siddha@intel.com>,
jbarnes@virtuousgeek.org, mingo@elte.hu, tglx@linutronix.de,
hpa@zytor.com, torvalds@linux-foundation.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] ioremap sanity check to catch mapping requests exceeding the BAR sizes
Date: Sat, 27 Sep 2008 12:24:01 -0700 [thread overview]
Message-ID: <48DE8851.9070900@linux.intel.com> (raw)
In-Reply-To: <20080927172546.6220ccbb@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Sat, 27 Sep 2008 07:43:55 -0700
> Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>> Alan Cox wrote:
>>>> Any attempt to use ioremap on memory is a bug, so you should warn about
>>>> that too.
>>>>
>>> We use it to ioremap things like the BIOS...
>> Yeah, that's fine. I mean using ioremap on system memory is a bug.
>
> On system memory mapped by the kernel which I assume is what you mean -
> the BIOS is often shadowed system memory and we have platforms where
> memory pages not mapped into or managed the OS are ioremap() targets.
>
> That however is getting pedantic - I just didn't want anyone to overdo
> the sanity checks
the existing sanity check checks to see if the kernel thinks if the memory is usable
for its own use, eg it uses the e820 table, the same one we use for feeding all memory
into the page allocator.
reserved and other similar types is not what ioremap complains about
prev parent reply other threads:[~2008-09-27 19:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 1:43 [patch] ioremap sanity check to catch mapping requests exceeding the BAR sizes Suresh Siddha
2008-09-26 7:39 ` Ingo Molnar
2008-09-26 8:10 ` Yinghai Lu
2008-09-26 8:12 ` Ingo Molnar
2008-09-26 8:35 ` Ingo Molnar
2008-09-26 9:46 ` [PATCH] x86, pci-hotplug, calgary / rio: fix EBDA ioremap() Ingo Molnar
2008-09-26 11:14 ` Arjan van de Ven
2008-09-27 16:35 ` Ingo Molnar
2008-09-27 7:16 ` [patch] ioremap sanity check to catch mapping requests exceeding the BAR sizes Jeremy Fitzhardinge
2008-09-27 11:21 ` Alan Cox
2008-09-27 14:43 ` Jeremy Fitzhardinge
2008-09-27 15:09 ` Arjan van de Ven
2008-09-27 16:17 ` Jeremy Fitzhardinge
2008-09-27 16:25 ` Alan Cox
2008-09-27 19:24 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DE8851.9070900@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox