Re: [PATCH] Markers : marker_synchronize_unregister()

[Lai Jiangshan <laijs@cn.fujitsu.com>]

Mathieu Desnoyers wrote:
> Create marker_synchronize_unregister() which must be called before the end of
> exit() to make sure every probe callers have exited the non preemptible section
> and thus are not executing the probe code anymore.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> CC: Ingo Molnar <mingo@elte.hu>
> CC: Rusty Russell <rusty@rustcorp.com.au>
> CC: akpm@linux-foundation.org
> CC: "Frank Ch. Eigler" <fche@redhat.com>
> ---
>  include/linux/marker.h |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> Index: linux-2.6-lttng/include/linux/marker.h
> ===================================================================
> --- linux-2.6-lttng.orig/include/linux/marker.h	2008-07-31 09:12:52.000000000 -0400
> +++ linux-2.6-lttng/include/linux/marker.h	2008-07-31 09:19:31.000000000 -0400
> @@ -142,4 +142,11 @@ extern int marker_probe_unregister_priva
>  extern void *marker_get_private_data(const char *name, marker_probe_func *probe,
>  	int num);
>  
> +/*
> + * marker_synchronize_unregister must be called between the last marker probe
> + * unregistration and the end of module exit to make sure there is no caller
> + * executing a probe when it is freed.
> + */

marker_synchronize_unregister must be called _also_ between unregistration
and destruction the data that unregistration-ed probes need to make sure
there is no caller executing a probe when it's data is destroyed.



> +#define marker_synchronize_unregister() synchronize_sched()
> +
>  #endif