BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

[Karol Lewandowski]

Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a causes my Thinkpad T21
to no longer generate any hotkey events (e.g. suspend fn-f4, switch-output
fn-f7, etc.) after resume.

It's regression from 2.6.25.  2.6.26 and 2.6.27-rc7 are broken,
reverting that commit on 2.6.27-rc7 makes keys work again.

Thanks.

[Rafael added for regression tracking ;]


commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Fri Jun 6 11:49:33 2008 -0400

    ACPI: EC: Use msleep instead of udelay while waiting for event.
    
    http://bugzilla.kernel.org/show_bug.cgi?id=10724
    
    Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
    Signed-off-by: Len Brown <len.brown@intel.com>

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 0924992..5622aee 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -194,7 +194,7 @@ static int acpi_ec_wait(struct acpi_ec *ec, enum ec_event event, int force_poll)
 		while (time_before(jiffies, delay)) {
 			if (acpi_ec_check_status(ec, event))
 				return 0;
-			udelay(ACPI_EC_UDELAY);
+			msleep(1);
 		}
 	}
 	pr_err(PREFIX "acpi_ec_wait timeout, status = 0x%2.2x, event = %s\n",

Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

[Rafael J. Wysocki]

On Tuesday, 30 of September 2008, Karol Lewandowski wrote:
> Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a causes my Thinkpad T21
> to no longer generate any hotkey events (e.g. suspend fn-f4, switch-output
> fn-f7, etc.) after resume.
> 
> It's regression from 2.6.25.  2.6.26 and 2.6.27-rc7 are broken,
> reverting that commit on 2.6.27-rc7 makes keys work again.
> 
> Thanks.
> 
> [Rafael added for regression tracking ;]
> 
> 
> commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a
> Author: Alexey Starikovskiy <astarikovskiy@suse.de>
> Date:   Fri Jun 6 11:49:33 2008 -0400
> 
>     ACPI: EC: Use msleep instead of udelay while waiting for event.
>     
>     http://bugzilla.kernel.org/show_bug.cgi?id=10724
>     
>     Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
>     Signed-off-by: Len Brown <len.brown@intel.com>
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 0924992..5622aee 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -194,7 +194,7 @@ static int acpi_ec_wait(struct acpi_ec *ec, enum ec_event event, int force_poll)
>  		while (time_before(jiffies, delay)) {
>  			if (acpi_ec_check_status(ec, event))
>  				return 0;
> -			udelay(ACPI_EC_UDELAY);
> +			msleep(1);
>  		}
>  	}
>  	pr_err(PREFIX "acpi_ec_wait timeout, status = 0x%2.2x, event = %s\n",

Can you see if the patch at
http://bugzilla.kernel.org/attachment.cgi?id=18044&action=view
(against current -git) helps?

Thanks,
Rafael

Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

[Karol Lewandowski]

On Tue, Sep 30, 2008 at 12:25:52AM +0200, Rafael J. Wysocki wrote:

> Can you see if the patch at
> http://bugzilla.kernel.org/attachment.cgi?id=18044&action=view
> (against current -git) helps?

It doesn't help (and -rc8 doesn't help either).

Thanks.

Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

[Alexey Starikovskiy]

Karol Lewandowski wrote:
> On Tue, Sep 30, 2008 at 12:25:52AM +0200, Rafael J. Wysocki wrote:
> 
>> Can you see if the patch at
>> http://bugzilla.kernel.org/attachment.cgi?id=18044&action=view
>> (against current -git) helps?
this patch is not in -rc8, and might even be postponed to 2.6.28-rc1.
> 
> It doesn't help (and -rc8 doesn't help either).
could you please uncomment "#define DEBUG" in the beginning of drivers/acpi/ec.c?
please also open bug report in bugzilla.kernel.org against ACPI and
attach dmesg from working and broken kernel with enabled DEBUG.
Let me know the number of bug report.
Thanks,
Alex.

Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

[Karol Lewandowski]

On Tue, Sep 30, 2008 at 08:46:07AM +0400, Alexey Starikovskiy wrote:
> Karol Lewandowski wrote:
> >On Tue, Sep 30, 2008 at 12:25:52AM +0200, Rafael J. Wysocki wrote:
> >
> >>Can you see if the patch at
> >>http://bugzilla.kernel.org/attachment.cgi?id=18044&action=view
> >>(against current -git) helps?
> this patch is not in -rc8, and might even be postponed to 2.6.28-rc1.
> >
> >It doesn't help (and -rc8 doesn't help either).
> could you please uncomment "#define DEBUG" in the beginning of 
> drivers/acpi/ec.c?
> please also open bug report in bugzilla.kernel.org against ACPI and
> attach dmesg from working and broken kernel with enabled DEBUG.
> Let me know the number of bug report.

It's http://bugzilla.kernel.org/show_bug.cgi?id=11674

Thanks.