From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Frank Mayhar <fmayhar@google.com>
Subject: Re: [PATCH -tip] sched: fix using uninilialzed rq in task_delta_exec()
Date: Tue, 30 Sep 2008 09:45:45 -0700 [thread overview]
Message-ID: <48E257B9.8020509@ct.jp.nec.com> (raw)
In-Reply-To: <20080930085850.GA27452@elte.hu>
Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
>
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>
>> compiler warnings;
>>
>> CC kernel/sched.o
>> kernel/sched.c: In function 'task_delta_exec':
>> kernel/sched.c:4055: warning: unused variable 'flags'
>> kernel/sched.c:4054: warning: 'rq' is used uninitialized in this function
>>
>> calling task_delta_exec() may cause unexpected pointer access.
>
> heh, just fixed that as well, latest tip/master should have the fix.
>
> Have you seen any weirdness due to this uninitialized variable?
No I've never seen any problem yesterday.
And I didn't have much time to use tip tree yesterday:)
Today's looks good.
thanks,
Hiroshi Shimamoto
prev parent reply other threads:[~2008-09-30 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 18:23 [PATCH -tip] sched: fix using uninilialzed rq in task_delta_exec() Hiroshi Shimamoto
2008-09-30 8:58 ` Ingo Molnar
2008-09-30 16:45 ` Hiroshi Shimamoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E257B9.8020509@ct.jp.nec.com \
--to=h-shimamoto@ct.jp.nec.com \
--cc=fmayhar@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox