From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754285AbYI3QrB (ORCPT ); Tue, 30 Sep 2008 12:47:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754121AbYI3Qqu (ORCPT ); Tue, 30 Sep 2008 12:46:50 -0400 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:58248 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbYI3Qqs (ORCPT ); Tue, 30 Sep 2008 12:46:48 -0400 Message-ID: <48E257B9.8020509@ct.jp.nec.com> Date: Tue, 30 Sep 2008 09:45:45 -0700 From: Hiroshi Shimamoto User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Ingo Molnar CC: linux-kernel@vger.kernel.org, Frank Mayhar Subject: Re: [PATCH -tip] sched: fix using uninilialzed rq in task_delta_exec() References: <48E11D0D.3040000@ct.jp.nec.com> <20080930085850.GA27452@elte.hu> In-Reply-To: <20080930085850.GA27452@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: > * Hiroshi Shimamoto wrote: > >> From: Hiroshi Shimamoto >> >> compiler warnings; >> >> CC kernel/sched.o >> kernel/sched.c: In function 'task_delta_exec': >> kernel/sched.c:4055: warning: unused variable 'flags' >> kernel/sched.c:4054: warning: 'rq' is used uninitialized in this function >> >> calling task_delta_exec() may cause unexpected pointer access. > > heh, just fixed that as well, latest tip/master should have the fix. > > Have you seen any weirdness due to this uninitialized variable? No I've never seen any problem yesterday. And I didn't have much time to use tip tree yesterday:) Today's looks good. thanks, Hiroshi Shimamoto