From: Jiri Slaby <jirislaby@gmail.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Vegard Nossum <vegardno@ifi.uio.no>, Ingo Molnar <mingo@elte.hu>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix virt_addr_valid() with CONFIG_DEBUG_VIRTUAL=y
Date: Wed, 01 Oct 2008 13:26:59 +0200 [thread overview]
Message-ID: <48E35E83.9040101@gmail.com> (raw)
In-Reply-To: <19f34abd0810010415s405dcd98j187e5c9c20fc2d16@mail.gmail.com>
On 10/01/2008 01:15 PM, Vegard Nossum wrote:
> On Wed, Oct 1, 2008 at 1:06 PM, Jiri Slaby <jirislaby@gmail.com> wrote:
>> x86_64 is screwed in the same way, isn't it?
>
> Hm. I didn't see any #ifdef CONFIG_DEBUG_VIRTUAL in the x86_64 code,
> so I assumed it wasn't. But it seems that you are right (because the
> checks, or at least some kind of checks, are _always_ performed on
> x86_64 regardless of the CONFIG_DEBUG_VIRTUAL setting). Why doesn't
> the checking in x86_64 code depend on DEBUG_VIRTUAL?
Yeah, it does: VIRTUAL_BUG_ON depends on it...
x86_64 just distinguish pointer to kernel image addresses (which are mapped only
up to kernel image size from phys_base physical address) and whole physical
memory map at another virtual address.
next prev parent reply other threads:[~2008-10-01 11:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 10:47 [PATCH] x86: fix virt_addr_valid() with CONFIG_DEBUG_VIRTUAL=y Vegard Nossum
2008-10-01 11:06 ` Jiri Slaby
2008-10-01 11:07 ` Jiri Slaby
2008-10-01 11:15 ` Vegard Nossum
2008-10-01 11:26 ` Jiri Slaby [this message]
2008-10-01 16:42 ` Vegard Nossum
2008-10-01 16:52 ` Andi Kleen
2008-10-01 19:32 ` Jiri Slaby
2008-10-01 19:46 ` Andi Kleen
2008-10-01 20:01 ` Jiri Slaby
2008-10-02 6:18 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E35E83.9040101@gmail.com \
--to=jirislaby@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vegard.nossum@gmail.com \
--cc=vegardno@ifi.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).