From: Jiri Slaby <jirislaby@gmail.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -tip] x86: fix virt_addr_valid() with CONFIG_DEBUG_VIRTUAL=y (try 2)
Date: Fri, 03 Oct 2008 16:23:51 +0200 [thread overview]
Message-ID: <48E62AF7.5040008@gmail.com> (raw)
In-Reply-To: <20081003140720.GA14261@localhost.localdomain>
Vegard Nossum napsal(a):
> How about this? It would apply to tip/x86/mm-debug. Untested.
It is wrong in my eyes -- it's workarounding of the real problem rather than
fixing. virt_addr_valid() should be fixed/augmented to the full virtual
address domain instead or not used for the purpose you need in kmemcheck.
As it is now, it should be used only on direct mapping addresses (more
concrete: kernel image space and physical mapping) and it returns
semi-random values on the rest -- with CONFIG_DEBUG_VIRTUAL=y it screams
instead of returning a bogus value.
next prev parent reply other threads:[~2008-10-03 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 14:07 [PATCH -tip] x86: fix virt_addr_valid() with CONFIG_DEBUG_VIRTUAL=y (try 2) Vegard Nossum
2008-10-03 14:23 ` Jiri Slaby [this message]
2008-10-03 15:54 ` Vegard Nossum
2008-10-03 18:11 ` Jiri Slaby
2008-10-04 8:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E62AF7.5040008@gmail.com \
--to=jirislaby@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox