From: "Matthew N. Dodd" <Matthew.Dodd@sparta.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: "David P. Quigley" <dpquigl@tycho.nsa.gov>,
hch@infradead.org, viro@zeniv.linux.org.uk,
casey@schaufler-ca.com, sds@tycho.nsa.gov,
trond.myklebust@fys.uio.no, bfields@fieldses.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
labeled-nfs@linux-nfs.org
Subject: Re: [PATCH 11/14] NFS/RPC: Add the auth_seclabel security flavor to allow the process label to be sent to the server.
Date: Fri, 03 Oct 2008 11:44:10 -0400 [thread overview]
Message-ID: <48E63DCA.1050700@sparta.com> (raw)
In-Reply-To: <20081003142342.GA9774@brain>
Andy Whitcroft wrote:
> On Mon, Sep 29, 2008 at 01:06:23PM -0400, David P. Quigley wrote:
> [...]
>>
>> + if (dom->flavour != &svcauth_unix
>> +#ifdef CONFIG_SECURITY
>> + && dom->flavour != &svcauth_seclabel
>> +#endif
>> + )
>> if (dom->flavour != &svcauth_unix)
>> return -EINVAL;
>> udom = container_of(dom, struct unix_domain, h);
>> @@ -873,3 +889,80 @@ struct auth_ops svcauth_unix = {
>> .set_client = svcauth_unix_set_client,
>> };
>
> checkpatch picked up on a suspect code indent for this hunk. It is
> unhappy about the second if expecting it to be indented. By the looks
> of this I am suspecting a miss-merge of the change in this function and
> the second if should have been removed. To my reading it actually still
> does the right thing but ...
This does appear to be a miss-merge.
next prev parent reply other threads:[~2008-10-03 15:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 17:06 [RFC v3] Security Label Support for NFSv4 David P. Quigley
2008-09-29 17:06 ` [PATCH 01/14] VFS: Factor out part of vfs_setxattr so it can be called from the SELinux hook for inode_setsecctx David P. Quigley
2008-09-30 19:51 ` Serge E. Hallyn
2008-09-29 17:06 ` [PATCH 05/14] SELinux: Add new labeling type native labels David P. Quigley
2008-09-29 17:06 ` [PATCH 06/14] KConfig: Add KConfig entries for Labeled NFS David P. Quigley
2008-09-30 20:40 ` Serge E. Hallyn
2008-09-29 17:06 ` [PATCH 08/14] NFS: Add security_label text mount option and handling code to NFS David P. Quigley
2008-09-29 17:06 ` [PATCH 10/14] NFSv4: Introduce new label structure David P. Quigley
2008-09-29 17:06 ` [PATCH 11/14] NFS/RPC: Add the auth_seclabel security flavor to allow the process label to be sent to the server David P. Quigley
2008-10-03 14:23 ` Andy Whitcroft
2008-10-03 15:44 ` Matthew N. Dodd [this message]
2008-09-29 17:06 ` [PATCH 13/14] NFS: Extend NFS xattr handlers to accept the security namespace David P. Quigley
[not found] ` <1222707986-26606-4-git-send-email-dpquigl@tycho.nsa.gov>
2008-09-30 20:15 ` [PATCH 03/14] Security: Add hook to calculate context based on a negative dentry Serge E. Hallyn
2008-10-10 17:54 ` David P. Quigley
2008-10-10 18:26 ` Serge E. Hallyn
[not found] ` <1222707986-26606-3-git-send-email-dpquigl@tycho.nsa.gov>
2008-09-30 20:01 ` [PATCH 02/14] LSM/SELinux: inode_{get,set,notify}secctx hooks to access LSM security context information Serge E. Hallyn
2008-10-06 20:52 ` David P. Quigley
2008-09-30 20:22 ` Serge E. Hallyn
2008-10-06 20:52 ` David P. Quigley
2008-10-13 23:31 ` [RFC v3] Security Label Support for NFSv4 James Morris
2008-10-14 2:15 ` [Labeled-nfs] " Matthew N. Dodd
2008-10-14 13:20 ` Trond Myklebust
2008-10-14 14:28 ` David P. Quigley
-- strict thread matches above, loose matches on Subject: below --
2008-09-15 20:41 [RFC] Labeled NFS Take 2 David P. Quigley
2008-09-15 20:41 ` [PATCH 11/14] NFS/RPC: Add the auth_seclabel security flavor to allow the process label to be sent to the server David P. Quigley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E63DCA.1050700@sparta.com \
--to=matthew.dodd@sparta.com \
--cc=apw@shadowen.org \
--cc=bfields@fieldses.org \
--cc=casey@schaufler-ca.com \
--cc=dpquigl@tycho.nsa.gov \
--cc=hch@infradead.org \
--cc=labeled-nfs@linux-nfs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=trond.myklebust@fys.uio.no \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox