public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Jenkins <aj504@student.cs.york.ac.uk>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH -tip] Tracing/fastboot: Only trace non-module initcalls
Date: Fri, 03 Oct 2008 18:43:39 +0100	[thread overview]
Message-ID: <48E659CB.5030902@tuffmail.co.uk> (raw)
In-Reply-To: <48E62089.7050006@gmail.com>

Frederic Weisbecker wrote:
> At this time, only built-in initcalls interest us.
> We can't really produce a relevant graph if we include
> the modules initcall too.
> 
> I had good results after this patch (see svg in attachment).

Sorry to butt in.  I think tracing module initcalls was a deliberate addition by Arjan (a06e1c2b448b317bc141934879cbbbed8319b4d4).

Maybe you use an initrd and that affects the trace?  It would be nice to see the "before" svg as well as the "after", to explain the change.

Thanks
Alan



  parent reply	other threads:[~2008-10-03 17:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 13:39 [PATCH -tip] Tracing/fastboot: Only trace non-module initcalls Frederic Weisbecker
2008-10-03 15:07 ` Ingo Molnar
2008-10-03 17:43 ` Alan Jenkins [this message]
2008-10-03 17:59   ` Frédéric Weisbecker
2008-10-03 18:07     ` Frédéric Weisbecker
2008-10-03 19:50     ` Alan Jenkins
2008-10-04 19:05       ` Frédéric Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E659CB.5030902@tuffmail.co.uk \
    --to=aj504@student.cs.york.ac.uk \
    --cc=arjan@infradead.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox