public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: Alan Jenkins <aj504@student.cs.york.ac.uk>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH -tip] Tracing/fastboot: Only trace non-module initcalls
Date: Fri, 03 Oct 2008 20:50:11 +0100	[thread overview]
Message-ID: <48E67773.50402@tuffmail.co.uk> (raw)
In-Reply-To: <c62985530810031059v5ed44e04qebaf9453710e76c1@mail.gmail.com>

Frédéric Weisbecker wrote:
> 2008/10/3 Alan Jenkins <aj504@student.cs.york.ac.uk>:
>   
>> Sorry to butt in.  I think tracing module initcalls was a deliberate addition by Arjan (a06e1c2b448b317bc141934879cbbbed8319b4d4).
>>
>> Maybe you use an initrd and that affects the trace?  It would be nice to see the "before" svg as well as the "after", to explain the change.
>>
>> Thanks
>> Alan
>>     
>
>
> Hi Alan,
>
> The script bootgraph.pl in -tip stops the analyzing when it sees
> "Freeing unused kernel memory". That's
> exactly when the built-in initcalls are finished.
> And as a result, the graph produced with dmesg always finishes at this point.
>
> If you try to generate a graph whithout this limitation, you will not
> be able to see something interesting because
> the script will not find a lot of initcalls with a long enough time
> proportion against the total boot time.
> Perhaps it can be improved in that way but unfortunately I don't know
> any word in Perl....
>   

If you want to disable non-module initcalls, then what do you have left
that you want to trace after "Freeing unused kernel memory"?

On my desktop dmesg I can see that the initramfs is loaded and started
some time before the initcalls finish.  The initramfs includes udev
which loads many modules; I see network, usb, sata being initialised
before the "Freeing unused kernel memory" message.  Um...  your changes
will _not_ stop the initcalls from these modules being shown.

So I think your patch description is a bit inaccurate, and I don't
understand what you are trying to achieve.

Thanks
Alan

  parent reply	other threads:[~2008-10-03 19:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 13:39 [PATCH -tip] Tracing/fastboot: Only trace non-module initcalls Frederic Weisbecker
2008-10-03 15:07 ` Ingo Molnar
2008-10-03 17:43 ` Alan Jenkins
2008-10-03 17:59   ` Frédéric Weisbecker
2008-10-03 18:07     ` Frédéric Weisbecker
2008-10-03 19:50     ` Alan Jenkins [this message]
2008-10-04 19:05       ` Frédéric Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E67773.50402@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=aj504@student.cs.york.ac.uk \
    --cc=arjan@infradead.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox