From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] x86: mtrr_cleanup: print out correct type
Date: Sat, 04 Oct 2008 17:42:40 -0700 [thread overview]
Message-ID: <48E80D80.2090900@zytor.com> (raw)
In-Reply-To: <1223157033-30217-1-git-send-email-yhlu.kernel@gmail.com>
Yinghai Lu wrote:
>
> Index: linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/cpu/mtrr/main.c
> +++ linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
> @@ -1273,12 +1273,14 @@ static int __init mtrr_cleanup(unsigned
> size_base = to_size_factor(size_base, &size_factor),
> start_base = range_state[i].base_pfn << (PAGE_SHIFT - 10);
> start_base = to_size_factor(start_base, &start_factor),
> + type = range_state[i].type;
>
> printk(KERN_DEBUG "reg %d, base: %ld%cB, range: %ld%cB, type %s\n",
> i, start_base, start_factor,
> size_base, size_factor,
> (type == MTRR_TYPE_UNCACHABLE) ? "UC" :
> - ((type == MTRR_TYPE_WRBACK) ? "WB" : "Other")
> + ((type == MTRR_TYPE_WRPROT) ? "WPROT" :
> + ((type == MTRR_TYPE_WRBACK) ? "WB" : "Other"))
> );
If you're going to abbreviate, please use the standard abbreviations as
documented in the manuals. The abbreviation for write protect is WP.
-hpa
next prev parent reply other threads:[~2008-10-05 0:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 21:50 [PATCH 1/3] x86: mtrr_cleanup: print out correct type Yinghai Lu
2008-10-04 21:50 ` [PATCH 2/3] x86: mtrr_cleanup: first 1M should be coverred in var mtrrs Yinghai Lu
2008-10-05 0:46 ` H. Peter Anvin
2008-10-05 1:49 ` Yinghai Lu
2008-10-05 1:52 ` H. Peter Anvin
2008-10-05 1:59 ` Yinghai Lu
2008-10-05 2:04 ` H. Peter Anvin
2008-10-04 21:50 ` [PATCH 3/3] x86: mtrr_cleanup: treat WRPROT as UNCACHEABLE Yinghai Lu
2008-10-05 0:42 ` H. Peter Anvin [this message]
2008-10-05 1:42 ` [PATCH 1/3] x86: mtrr_cleanup: print out correct type Yinghai Lu
2008-10-05 3:10 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E80D80.2090900@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox