Re: patch sata_nv-disable-hardreset-for-generic.patch added to 2.6.26-stable tree

Stefan Lippers-Hollmann
2008-10-05T16:00:32Z

[-- Attachment #1: Type: text/plain, Size: 2302 bytes --]

Hi

On Sonntag, 5. Oktober 2008, Greg KH wrote:
> On Sat, Oct 04, 2008 at 06:27:03PM +0200, Stefan Lippers-Hollmann wrote:
> > Hi
> >
> > On Donnerstag, 2. Oktober 2008, gregkh@suse.de wrote:
> > >
> > > This is a note to let you know that we have just queued up the patch titled
> > >
> > > Subject: sata_nv: disable hardreset for generic
> > >
> > > to the 2.6.26-stable tree. Its filename is
> > >
> > > sata_nv-disable-hardreset-for-generic.patch
> > >
> > > A git repo of this tree can be found at
> > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > >
> > >
> > > From 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 Mon Sep 17 00:00:00 2001
> > > From: Tejun Heo <tj@kernel.org>
> > > Date: Fri, 29 Aug 2008 16:13:12 +0200
> > > Subject: sata_nv: disable hardreset for generic
> > >
> > > From: Tejun Heo <tj@kernel.org>
> > >
> > > commit 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 upstream
> > >
> > > of them being unifying probing, hotplug and EH reset paths uniform.
> > > Previously, broken hardreset could go unnoticed as it wasn't used
> > > during probing but when something goes wrong or after hotplug the
> > > problem will surface and bite hard.
> > >
> > > OSDL bug 11195 reports that sata_nv generic flavor falls into this
> > > category. Hardreset itself succeeds but PHY stays offline after
> > > hardreset. I tried longer debounce timing but the result was the
> > > same.
> > >
> > > http://bugzilla.kernel.org/show_bug.cgi?id=11195
> > >
> > > So, it seems we'll have to drop hardreset from the generic flavor.
> > >
> > > Signed-off-by: Tejun Heo <tj@kernel.org>
> > > Cc: Peer Chen <pchen@nvidia.com>
> > > Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >
> > On 2.6.26.5 + the pending stable queue applied, this patch results in lots
> > of noise in my syslog (full gzipped dmesg with and without this patch
> > attached):
>
> This patch has been removed from the stable queue, so it shouldn't be an
> issue anymore, right?

Yes, you're right. I missed it being removed from queue-2.6.26 a few hours
before I actually sent the mail, sorry for the noise.

Thanks
Stefan Lippers-Hollmann

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]