Re: [patch] Re: how to link to hrtimers in the kernel

Thomas Gleixner
2008-10-06T16:52:14Z

On Mon, 6 Oct 2008, Randy.Dunlap wrote:
> On Mon, 6 Oct 2008, George Nychis wrote:
>
> > Hi all,
> >
> > I have modified drivers/usb/core/devio.c to use hrtimer_nanosleep(), and have
> > included linux/hrtimer.h with it.

Please do not use hrtimer_nanosleep() in drivers. That's
wrong.

What do you want to achieve ?

> Export hrtimer_nanosleep() for module use.

NAK, hrtimer_nanosleep is part of the user space interfaces.

> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> kernel/hrtimer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-2.6.27-rc8-git5.orig/kernel/hrtimer.c
> +++ linux-2.6.27-rc8-git5/kernel/hrtimer.c
> @@ -1559,6 +1559,7 @@ out:
> destroy_hrtimer_on_stack(&t.timer);
> return ret;
> }
> +EXPORT_SYMBOL_GPL(hrtimer_nanosleep);
>
> asmlinkage long
> sys_nanosleep(struct timespec __user *rqtp, struct timespec __user *rmtp)
>