From: David Daney <ddaney@caviumnetworks.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, "Paoletti,
Tomaso" <Tomaso.Paoletti@caviumnetworks.com>
Subject: Re: [PATCH 1/4] serial: 8250 driver replaceable i/o functions.
Date: Tue, 07 Oct 2008 17:29:25 -0700 [thread overview]
Message-ID: <48EBFEE5.7010401@caviumnetworks.com> (raw)
In-Reply-To: <48EBFAFC.3020501@zytor.com>
H. Peter Anvin wrote:
> David Daney wrote:
>> /* sane hardware needs no mapping */
>> -static inline int map_8250_in_reg(struct uart_8250_port *up, int offset)
>> +static inline int map_8250_in_reg(struct uart_port *p, int offset)
>> {
>> - if (up->port.iotype != UPIO_AU)
>> + if (p->iotype != UPIO_AU)
>> return offset;
>> return au_io_in_map[offset];
>> }
>
> With your changes, these functions cannot be called with p->iotype !=
> UPIO_AU anymore, correct? So there is no need for this test...
>
I think you are probably correct. However, with the patch it is
possible to move all this target specific code out of the driver. So if
the patch is accepted, a better follow up would be to get rid of the
UPIO_AU things altogether.
I gave an example of how that could be done with UPIO_TSI here:
http://marc.info/?l=linux-serial&m=122333633802691&w=2
David Daney
next prev parent reply other threads:[~2008-10-08 0:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 23:43 [PATCH 0/4] serial: 8250 driver improvements & Cavium OCTEON serial support David Daney
2008-10-07 23:49 ` [PATCH 1/4] serial: 8250 driver replaceable i/o functions David Daney
2008-10-08 0:12 ` H. Peter Anvin
2008-10-08 0:29 ` David Daney [this message]
2008-10-07 23:52 ` [PATCH 2/4] serial: Allow port type to be specified when calling serial8250_register_port David Daney
2008-10-07 23:57 ` [PATCH 3/4] serial: Allow port type to specify bugs that are not probed for David Daney
2008-10-07 23:59 ` [PATCH 4/4] serial: Add new uart_config for PORT_OCTEON David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EBFEE5.7010401@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=Tomaso.Paoletti@caviumnetworks.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox