From: Tobias Brunner <tobias.brunner@strongswan.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.27-rc9] af_key: fix SADB_X_SPDDELETE response
Date: Thu, 09 Oct 2008 14:10:21 +0200 [thread overview]
Message-ID: <48EDF4AD.50907@strongswan.org> (raw)
When deleting an SPD entry using SADB_X_SPDDELETE, c.data.byid is not
initialized to zero in pfkey_spddelete(). Thus, key_notify_policy()
responds with a PF_KEY message of type SADB_X_SPDDELETE2 instead of
SADB_X_SPDDELETE.
Signed-off-by: Tobias Brunner <tobias.brunner@strongswan.org>
--- a/net/key/af_key.c 2008-10-09 13:10:04.000000000 +0200
+++ b/net/key/af_key.c 2008-10-09 13:49:11.000000000 +0200
@@ -2317,6 +2317,7 @@
c.seq = hdr->sadb_msg_seq;
c.pid = hdr->sadb_msg_pid;
+ c.data.byid = 0;
c.event = XFRM_MSG_DELPOLICY;
km_policy_notify(xp, pol->sadb_x_policy_dir-1, &c);
next reply other threads:[~2008-10-09 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 12:10 Tobias Brunner [this message]
2008-10-09 21:44 ` [PATCH 2.6.27-rc9] af_key: fix SADB_X_SPDDELETE response David Miller
2008-10-10 8:23 ` Tobias Brunner
2008-10-10 16:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EDF4AD.50907@strongswan.org \
--to=tobias.brunner@strongswan.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox