[PATCH 2.6.27-rc9] af_key: fix SADB_X_SPDDELETE response

[PATCH 2.6.27-rc9] af_key: fix SADB_X_SPDDELETE response

[Tobias Brunner]

When deleting an SPD entry using SADB_X_SPDDELETE, c.data.byid is not 
initialized to zero in pfkey_spddelete(). Thus, key_notify_policy() 
responds with a PF_KEY message of type SADB_X_SPDDELETE2 instead of 
SADB_X_SPDDELETE.

Signed-off-by: Tobias Brunner <tobias.brunner@strongswan.org>

--- a/net/key/af_key.c	2008-10-09 13:10:04.000000000 +0200
+++ b/net/key/af_key.c	2008-10-09 13:49:11.000000000 +0200
@@ -2317,6 +2317,7 @@
 
 	c.seq = hdr->sadb_msg_seq;
 	c.pid = hdr->sadb_msg_pid;
+	c.data.byid = 0;
 	c.event = XFRM_MSG_DELPOLICY;
 	km_policy_notify(xp, pol->sadb_x_policy_dir-1, &c);
 

Re: [PATCH 2.6.27-rc9] af_key: fix SADB_X_SPDDELETE response

[David Miller]

From: Tobias Brunner <tobias.brunner@strongswan.org>
Date: Thu, 09 Oct 2008 14:10:21 +0200

> When deleting an SPD entry using SADB_X_SPDDELETE, c.data.byid is not initialized to zero in pfkey_spddelete(). Thus, key_notify_policy() responds with a PF_KEY message of type SADB_X_SPDDELETE2 instead of SADB_X_SPDDELETE.
> 
> Signed-off-by: Tobias Brunner <tobias.brunner@strongswan.org>

This patch does not apply cleanly to net-next-2.6, a lot has
changed in this area over the past several weeks.

Please respin this so that I can add it, thanks.

Re: [PATCH 2.6.27-rc9] af_key: fix SADB_X_SPDDELETE response

[Tobias Brunner]

David Miller wrote:
> This patch does not apply cleanly to net-next-2.6, a lot has
> changed in this area over the past several weeks.
> 
> Please respin this so that I can add it, thanks.

Please find the patch for net-next-2.6 below.

Thanks,
	Tobias

---

diff --git a/net/key/af_key.c b/net/key/af_key.c
index 362fe31..e55e044 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -2341,6 +2341,7 @@ static int pfkey_spddelete(struct sock *sk, struct sk_buff *skb, struct sadb_msg
 
 	c.seq = hdr->sadb_msg_seq;
 	c.pid = hdr->sadb_msg_pid;
+	c.data.byid = 0;
 	c.event = XFRM_MSG_DELPOLICY;
 	km_policy_notify(xp, pol->sadb_x_policy_dir-1, &c);
 

Re: [PATCH 2.6.27-rc9] af_key: fix SADB_X_SPDDELETE response

[David Miller]

From: Tobias Brunner <tobias.brunner@strongswan.org>
Date: Fri, 10 Oct 2008 10:23:36 +0200

> David Miller wrote:
> > This patch does not apply cleanly to net-next-2.6, a lot has
> > changed in this area over the past several weeks.
> > Please respin this so that I can add it, thanks.
> 
> Please find the patch for net-next-2.6 below.

Please resubmit:

1) At least CC:'d to the correct mailing list, netdev@vger.kernel.org

   This is important so that the patch gets tracked at:

	http://patchwork.ozlabs.org/project/netdev/list/

2) With full commit log message and signoffs presented again.

Thanks.