From: "Zhao, Yu" <yu.zhao@intel.com>
To: Alex Chiang <achiang@hp.com>, "Zhao, Yu" <yu.zhao@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
Grant Grundler <grundler@parisc-linux.org>,
Matthew Wilcox <matthew@wil.cx>,
Roland Dreier <rdreier@cisco.com>, Greg KH <greg@kroah.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 4/6 v3] PCI: support SR-IOV capability
Date: Fri, 10 Oct 2008 15:24:49 +0800 [thread overview]
Message-ID: <48EF0341.9040703@intel.com> (raw)
In-Reply-To: <20080930223851.GC13611@ldl.fc.hp.com>
Alex Chiang wrote:
> Do you want to emit a kobject_uevent here after success?
>
> Alternatively, have you investigated making these virtual
> functions into real struct device's? You get a lot of sysfs stuff
> for free if you do so, including correct place in sysfs hierarchy
> and uevents, etc.
The virtual functions are rpresented by 'struct pci_dev', so same as
real device, the standard sysfs entries are created by pci_bus_add_device.
>
> My major complaints from last round (more documentation,
> shouldn't be a PCI hotplug driver) have been addressed. I'll let
> others comment about the other parts of your patch series.
Thanks, Alex.
>
> Thanks.
>
> /ac
>
next prev parent reply other threads:[~2008-10-10 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 8:28 [PATCH 4/6 v3] PCI: support SR-IOV capability Zhao, Yu
2008-09-30 22:38 ` Alex Chiang
2008-10-10 7:24 ` Zhao, Yu [this message]
2008-09-30 22:40 ` Roland Dreier
2008-10-08 2:49 ` Zhao, Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EF0341.9040703@intel.com \
--to=yu.zhao@intel.com \
--cc=achiang@hp.com \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox