From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754273AbYJJH0d (ORCPT ); Fri, 10 Oct 2008 03:26:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751835AbYJJH0X (ORCPT ); Fri, 10 Oct 2008 03:26:23 -0400 Received: from mga14.intel.com ([143.182.124.37]:37136 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbYJJH0W (ORCPT ); Fri, 10 Oct 2008 03:26:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.33,387,1220252400"; d="scan'208";a="57784515" Message-ID: <48EF0341.9040703@intel.com> Date: Fri, 10 Oct 2008 15:24:49 +0800 From: "Zhao, Yu" User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Alex Chiang , "Zhao, Yu" , "linux-pci@vger.kernel.org" , Randy Dunlap , Grant Grundler , Matthew Wilcox , Roland Dreier , Greg KH , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH 4/6 v3] PCI: support SR-IOV capability References: <20080930223851.GC13611@ldl.fc.hp.com> In-Reply-To: <20080930223851.GC13611@ldl.fc.hp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alex Chiang wrote: > Do you want to emit a kobject_uevent here after success? > > Alternatively, have you investigated making these virtual > functions into real struct device's? You get a lot of sysfs stuff > for free if you do so, including correct place in sysfs hierarchy > and uevents, etc. The virtual functions are rpresented by 'struct pci_dev', so same as real device, the standard sysfs entries are created by pci_bus_add_device. > > My major complaints from last round (more documentation, > shouldn't be a PCI hotplug driver) have been addressed. I'll let > others comment about the other parts of your patch series. Thanks, Alex. > > Thanks. > > /ac >