From: Cedric Le Goater <clg@fr.ibm.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Oren Laadan <orenl@cs.columbia.edu>,
containers@lists.linux-foundation.org,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [RFC][PATCH 2/2] first callers of process_deny_checkpoint()
Date: Fri, 10 Oct 2008 12:17:15 +0200 [thread overview]
Message-ID: <48EF2BAB.1010009@fr.ibm.com> (raw)
In-Reply-To: <20081009190406.1B257119@kernel>
> diff -puN ipc/mqueue.c~no-checkpointing-for-sockets ipc/mqueue.c
> --- linux-2.6.git/ipc/mqueue.c~no-checkpointing-for-sockets 2008-10-09 11:56:58.000000000 -0700
> +++ linux-2.6.git-dave/ipc/mqueue.c 2008-10-09 11:56:58.000000000 -0700
> @@ -14,6 +14,7 @@
> */
>
> #include <linux/capability.h>
> +#include <linux/checkpoint.h>
> #include <linux/init.h>
> #include <linux/pagemap.h>
> #include <linux/file.h>
> @@ -655,6 +656,8 @@ asmlinkage long sys_mq_open(const char _
> char *name;
> int fd, error;
>
> + process_deny_checkpointing(current);
> +
mqueue being a file system, i would put the checks in the inode_operations.
Also, you can't always deny ! I would expect some allow in sys_mq_unlink().
C.
next prev parent reply other threads:[~2008-10-10 10:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 19:04 [RFC][PATCH 1/2] Track in-kernel when we expect checkpoint/restart to work Dave Hansen
2008-10-09 19:04 ` [RFC][PATCH 2/2] first callers of process_deny_checkpoint() Dave Hansen
2008-10-09 19:43 ` Serge E. Hallyn
2008-10-09 20:54 ` Dave Hansen
2008-10-10 8:46 ` Ingo Molnar
2008-10-10 13:17 ` Rafael J. Wysocki
2008-10-10 14:54 ` Ingo Molnar
2008-10-10 19:53 ` Rafael J. Wysocki
2008-10-10 19:53 ` Ingo Molnar
2008-10-10 20:40 ` Len Brown
2008-10-10 22:57 ` Rafael J. Wysocki
2008-10-11 13:48 ` Pavel Machek
2008-10-11 15:00 ` Ingo Molnar
2008-10-10 10:27 ` Cedric Le Goater
2008-10-10 8:41 ` Daniel Lezcano
2008-10-10 10:17 ` Cedric Le Goater [this message]
2008-10-10 14:04 ` Serge E. Hallyn
2008-10-10 16:45 ` Greg Kurz
2008-10-10 17:13 ` Serge E. Hallyn
2008-10-10 17:28 ` Dave Hansen
2008-10-13 8:20 ` Greg Kurz
2008-10-10 8:20 ` [RFC][PATCH 1/2] Track in-kernel when we expect checkpoint/restart to work Greg Kurz
2008-10-10 8:37 ` Daniel Lezcano
2008-10-10 8:47 ` Greg Kurz
2008-10-10 10:11 ` Oren Laadan
2008-10-10 14:59 ` Ingo Molnar
2008-10-10 15:17 ` Oren Laadan
2008-10-10 15:28 ` Ingo Molnar
2008-10-10 16:34 ` Greg Kurz
2008-10-10 16:36 ` Dave Hansen
2008-10-10 20:57 ` Daniel Lezcano
2008-10-10 17:18 ` Chris Friesen
2008-10-13 8:18 ` Greg Kurz
2008-10-13 16:46 ` Serge E. Hallyn
2008-10-10 16:33 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EF2BAB.1010009@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=arnd@arndb.de \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=orenl@cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox