From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763485AbYJJUgZ (ORCPT ); Fri, 10 Oct 2008 16:36:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757975AbYJJUgR (ORCPT ); Fri, 10 Oct 2008 16:36:17 -0400 Received: from adelie.canonical.com ([91.189.90.139]:58071 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbYJJUgQ (ORCPT ); Fri, 10 Oct 2008 16:36:16 -0400 Message-ID: <48EFBCBB.6050104@canonical.com> Date: Fri, 10 Oct 2008 16:36:11 -0400 From: Stefan Bader User-Agent: Thunderbird 2.0.0.17 (X11/20080925) MIME-Version: 1.0 To: Greg KH CC: Ingo Molnar , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Thomas Gleixner , Yinghai Lu , stable@kernel.org Subject: Re: [stable] [PATCH] x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap References: <48EFB4B2.2020508@canonical.com> <20081010201610.GA32164@kroah.com> <20081010202350.GA11090@elte.hu> <20081010202915.GA32318@kroah.com> In-Reply-To: <20081010202915.GA32318@kroah.com> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH wrote: > On Fri, Oct 10, 2008 at 10:23:50PM +0200, Ingo Molnar wrote: >> * Greg KH wrote: >> >>> On Fri, Oct 10, 2008 at 04:01:54PM -0400, Stefan Bader wrote: >>>> Affected: 2.6.24-2.6.27 >>>> >>>> Someone from the community found out, that after repeatedly unloading and >>>> loading a device driver that uses MSI IRQs, the system eventually assigned >>>> the vector initially reserved for IRQ0 to the device driver. >>>> >>>> The reason for this is, that although IRQ0 is tied to the FIRST_DEVICE_VECTOR >>>> when declaring the irq_vector table, the corresponding bit in the used_vectors >>>> map is not set. So, if vectors are released and assigned often enough, the >>>> vector will get assigned to another interrupt. This happens more often with >>>> MSI interrupts as those are exclusively using a vector. >>>> >>>> Fix this by setting the bit for the FIRST_DEVICE_VECTOR in the bitmap. >>>> >>>> Signed-off-by: Stefan Bader >>> Hint, if you want patches to go into the -stable tree, just add: >>> cc: Stable >>> to the patch when you submit it in the signed-off-by area, and it will >>> be automatically sent to us when it goes into the main kernel tree. >> yes. Note that this is a special case, as there will be no upstream >> commit to tag with Cc: , because this bug got >> eliminated via not backportable means: APIC code unification. >> >> Acked-by: Ingo Molnar > > So this is a -stable release only patch? .28 will never get/need this? > > thanks, > > greg k-h Correct. Tried to hint this by the Affected line but should have been more verbose. Regards, Stefan -- When all other means of communication fail, try words!