From: Randy Dunlap <randy.dunlap@oracle.com>
To: Neshama Parhoti <pneshama@gmail.com>
Cc: Adrian Bunk <bunk@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: section mismatch with a platform driver
Date: Mon, 13 Oct 2008 09:31:48 -0700 [thread overview]
Message-ID: <48F377F4.7070502@oracle.com> (raw)
In-Reply-To: <912ec82a0810130929h42574fav985e922ad019b8f5@mail.gmail.com>
Neshama Parhoti wrote:
> On Mon, Oct 13, 2008 at 6:01 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> A probe function can be called at any time -- i.e., after system init
>> has completed, so discarding the __init function my_probe_func() is BAD,
>> dangerous, BUGgy.
>
> Thanks for the explanation!
>
> Does that mean that all drivers with __init in their probe functions are bogus ?
It depends. If your platform doesn't support hotplug, then it's possible
that the probe function is only called during system init, so it would be OK.
And in general, if a kernel is built without hotplug support, then the
__init probe functions are probably safe. But I'm not sure about it.
--
~Randy
next prev parent reply other threads:[~2008-10-13 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 8:19 section mismatch with a platform driver Neshama Parhoti
2008-10-13 8:51 ` Adrian Bunk
2008-10-13 9:28 ` Neshama Parhoti
2008-10-13 9:43 ` Gilad Ben-Yossef
2008-10-13 11:11 ` Neshama Parhoti
2008-10-13 9:50 ` Adrian Bunk
2008-10-13 11:13 ` Neshama Parhoti
2008-10-13 16:01 ` Randy Dunlap
2008-10-13 16:29 ` Neshama Parhoti
2008-10-13 16:31 ` Randy Dunlap [this message]
2008-10-13 18:58 ` Neshama Parhoti
2008-10-13 19:00 ` Randy Dunlap
2008-10-13 20:22 ` sniper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F377F4.7070502@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pneshama@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox