Re: Please pull arch perfmon update

Andi Kleen
2008-10-13T20:30:08Z

>
> I applied your patches to the x86-oprofile-for-tip branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git

Will that still make 2.6.28?

> I added a follow on patch (446223f) on branch arch-perfmon that

I didn't do that intentionally because it's called too late.
The function really has to be called early, so that the fallback
works.

> There is one question to patch "oprofile: discover counters for op
> ppro too". arch_perfmon_setup_counters() is actually never called for
> ppro, so there is no code that changes the numbers in
> op_ppro_spec. The patch as it is has no effect (except then loading
> additional module code).

Ah true, i must have deleted one hunk too much while refactoring.
It's ok to drop this patch for now.

-Andi