From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tony Luck <tony.luck@intel.com>,
Yinghai Lu <yhlu.kernel@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
tglx@linutronix.de, jbarnes@virtuousgeek.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: split e820 reserved entries record to late v4 - fix v7
Date: Mon, 13 Oct 2008 14:54:08 -0700 [thread overview]
Message-ID: <48F3C380.2020603@zytor.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0810131431510.3288@nehalem.linux-foundation.org>
Linus Torvalds wrote:
>
> Or we could do what Andrew suggested some time ago, and extend %p to do
> resource printing, like %pS and %pF.
>
> TOTALLY UNTESTED! But something like this might allow
>
> printk(KERN_DEBUG " reserve_region: (%s) %pR\n"
> res->name, res);
>
> and if I did things right it should print
>
> reserve_region: (name) [xx-xx]
>
> and maybe it's worth it. We certainly do seem to have a fair number of
> those irritating casts for resource printouts.
>
There is certainly a lot to be said for this. Using higher-level
interfaces keeps formatting consistent and gives us one place to change
things if desired.
-hpa
next prev parent reply other threads:[~2008-10-13 21:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 7:31 [PATCH] x86: split e820 reserved entries record to late v4 - fix v7 Yinghai Lu
2008-09-04 19:04 ` Ingo Molnar
2008-09-04 19:16 ` Andrew Morton
2008-09-04 19:22 ` Yinghai Lu
2008-10-13 20:32 ` Tony Luck
2008-10-13 21:14 ` H. Peter Anvin
2008-10-13 21:17 ` Luck, Tony
2008-10-13 21:46 ` Linus Torvalds
2008-10-13 21:54 ` H. Peter Anvin [this message]
2008-10-13 22:40 ` Yinghai Lu
2008-10-13 22:48 ` H. Peter Anvin
2008-10-14 5:29 ` Yinghai Lu
2008-09-05 8:52 ` Yinghai Lu
2008-09-05 11:45 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F3C380.2020603@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox