From: "H. Peter Anvin" <hpa@zytor.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
yhlu.kernel@gmail.com
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()
Date: Mon, 13 Oct 2008 18:04:20 -0700 [thread overview]
Message-ID: <48F3F014.3050406@zytor.com> (raw)
In-Reply-To: <20081014005428.EC2D8DDF93@ozlabs.org>
Benjamin Herrenschmidt wrote:
> That debug outpout in kernel/resource.c is busted on 32-bit
> machines, fix it with appropriate casts.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> One day Yinghai will figure out that resource_size_t can be 32-bit
> and thus as printk arguments must be cast to (unsigned long long)
> explicitely when using %llx... hopefully, that day, Ingo will also
> catch these before committing them as it's not the first one like
> this :-)
>
I really think Linus' solution (add a resource printf modifier, that can
contain the whole format) is much better.
-hpa
next prev parent reply other threads:[~2008-10-14 1:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 0:53 [PATCH] Fix broken debug output reserve_region_with_split() Benjamin Herrenschmidt
2008-10-14 1:04 ` H. Peter Anvin [this message]
2008-10-14 1:14 ` Yinghai Lu
2008-10-14 1:16 ` H. Peter Anvin
2008-10-14 1:34 ` David Miller
2008-10-14 1:41 ` Benjamin Herrenschmidt
2008-10-14 1:41 ` Benjamin Herrenschmidt
2008-10-14 1:45 ` David Miller
2008-10-14 2:15 ` Benjamin Herrenschmidt
2008-10-14 2:54 ` H. Peter Anvin
2008-10-14 3:47 ` Benjamin Herrenschmidt
2008-10-14 5:38 ` David Miller
2008-10-16 8:30 ` Geert Uytterhoeven
2008-10-16 8:38 ` David Miller
2008-10-16 9:02 ` H. Peter Anvin
2008-10-17 3:02 ` Benjamin Herrenschmidt
2008-10-17 3:06 ` Benjamin Herrenschmidt
2008-10-17 3:13 ` Roland Dreier
2008-10-17 3:31 ` Benjamin Herrenschmidt
2008-10-17 3:49 ` Linus Torvalds
2008-10-17 4:04 ` David Miller
2008-10-17 4:18 ` Linus Torvalds
2008-10-17 5:00 ` Benjamin Herrenschmidt
2008-10-17 5:24 ` David Miller
2008-10-17 5:12 ` Benjamin Herrenschmidt
2008-10-17 5:21 ` Benjamin Herrenschmidt
2008-10-17 10:13 ` Olivier Galibert
2008-10-17 15:54 ` Linus Torvalds
2008-10-17 20:30 ` H. Peter Anvin
2008-10-17 20:54 ` Linus Torvalds
2008-10-17 21:03 ` Benjamin Herrenschmidt
2008-10-17 21:11 ` Linus Torvalds
2008-10-17 21:45 ` Benjamin Herrenschmidt
2008-10-20 3:37 ` Benjamin Herrenschmidt
2008-10-17 5:21 ` David Miller
2008-10-17 6:36 ` Benjamin Herrenschmidt
2008-10-17 6:39 ` H. Peter Anvin
2008-10-17 6:47 ` David Miller
2008-10-17 6:51 ` H. Peter Anvin
2008-10-17 15:51 ` Linus Torvalds
2008-10-17 20:06 ` David Miller
2008-10-17 4:05 ` Benjamin Herrenschmidt
2008-10-17 6:36 ` H. Peter Anvin
2008-10-17 3:39 ` Yinghai Lu
2008-10-17 3:46 ` Benjamin Herrenschmidt
2008-10-17 6:38 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F3F014.3050406@zytor.com \
--to=hpa@zytor.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox