Re: Avoid I/O errors when issuing SCSI ioctls to JMicron USB/ATA bridge

[Phil Dibowitz <phil@ipom.com>]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

Alexandre Oliva wrote:
> Here's the patch that implements the fix you suggested to avoid the
> I/O errors that I was running into with my new USB enclosure with a
> JMicron USB/ATA bridge, while issuing scsi-io USN or other such
> queries used by Fedora's mkinitrd.
> http://bugzilla.kernel.org/show_bug.cgi?id=9638#c85

Alexandre,

The patch looks generally good, but you've included every possible revision
of the hardware. Can you please change your patch to include just the
revision in question (0x0100) rather than the whole range (0x0000 - 0x9999)?

Thanks.
-- 
Phil Dibowitz                             phil@ipom.com
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]