Re: Avoid I/O errors when issuing SCSI ioctls to JMicron USB/ATA bridge

Re: Avoid I/O errors when issuing SCSI ioctls to JMicron USB/ATA bridge

[Phil Dibowitz]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

Alexandre Oliva wrote:
> Here's the patch that implements the fix you suggested to avoid the
> I/O errors that I was running into with my new USB enclosure with a
> JMicron USB/ATA bridge, while issuing scsi-io USN or other such
> queries used by Fedora's mkinitrd.
> http://bugzilla.kernel.org/show_bug.cgi?id=9638#c85

Alexandre,

The patch looks generally good, but you've included every possible revision
of the hardware. Can you please change your patch to include just the
revision in question (0x0100) rather than the whole range (0x0000 - 0x9999)?

Thanks.
-- 
Phil Dibowitz                             phil@ipom.com
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

Re: Avoid I/O errors when issuing SCSI ioctls to JMicron USB/ATA bridge

[Alexandre Oliva]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

On Oct 14, 2008, Phil Dibowitz <phil@ipom.com> wrote:

> The patch looks generally good, but you've included every possible revision
> of the hardware. Can you please change your patch to include just the
> revision in question (0x0100) rather than the whole range (0x0000 - 0x9999)?

Here's the patch.  Let's hope that's enough to cover any other
failing variants, past, present and future.


>> Here's the patch that implements the fix you suggested to avoid the
>> I/O errors that I was running into with my new USB enclosure with a
>> JMicron USB/ATA bridge, while issuing scsi-io USN or other such
>> queries used by Fedora's mkinitrd.
>> http://bugzilla.kernel.org/show_bug.cgi?id=9638#c85


/proc/bus/usb/devices:
T:  Bus=01 Lev=01 Prnt=01 Port=07 Cnt=04 Dev#=  5 Spd=480 MxCh= 0
D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=152d ProdID=2329 Rev= 1.00
S:  Manufacturer=JMicron
S:  Product=USB to ATA/ATAPI Bridge
S:  SerialNumber=DE5088854FFF
C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=  2mA
I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

(patch applied and retested on a modified 2.6.27.2-libre.24.rc1.fc10)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: lxo-usb-jmicron-ignore-residue.patch --]
[-- Type: text/x-patch, Size: 802 bytes --]

--- linux-2.6/drivers/usb/storage/unusual_devs.h~	2008-07-13 18:51:29.000000000 -0300
+++ linux-2.6/drivers/usb/storage/unusual_devs.h	2008-10-07 23:38:38.000000000 -0300
@@ -1694,6 +1694,15 @@
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_IGNORE_RESIDUE ),
 
+/* Reported by Alexandre Oliva <oliva@lsd.ic.unicamp.br>
+ * JMicron responds to USN and several other SCSI ioctls with a
+ * residue that causes subsequent I/O requests to fail.  */
+UNUSUAL_DEV(  0x152d, 0x2329, 0x0100, 0x0100,
+	        "JMicron",
+	        "USB to ATA/ATAPI Bridge",
+	        US_SC_DEVICE, US_PR_DEVICE, NULL,
+	        US_FL_IGNORE_RESIDUE ),
+
 /* Reported by Robert Schedel <r.schedel@yahoo.de>
  * Note: this is a 'super top' device like the above 14cd/6600 device */
 UNUSUAL_DEV(  0x1652, 0x6600, 0x0201, 0x0201,

[-- Attachment #3: Type: text/plain, Size: 257 bytes --]


-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}
FSFLA Board Member       ¡Sé Libre! => http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}

Avoid I/O errors when issuing SCSI ioctls to JMicron USB/ATA bridge

[Alexandre Oliva]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

Hi, Alan,

Here's the patch that implements the fix you suggested to avoid the
I/O errors that I was running into with my new USB enclosure with a
JMicron USB/ATA bridge, while issuing scsi-io USN or other such
queries used by Fedora's mkinitrd.
http://bugzilla.kernel.org/show_bug.cgi?id=9638#c85

/proc/bus/usb/devices:
T:  Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  2 Spd=480 MxCh= 0
D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=152d ProdID=2329 Rev= 1.00
S:  Manufacturer=JMicron
S:  Product=USB to ATA/ATAPI Bridge
S:  SerialNumber=152D20329000
C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=  2mA
I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: lxo-usb-jmicron-ignore-residue.patch --]
[-- Type: text/x-patch, Size: 802 bytes --]

--- linux-2.6/drivers/usb/storage/unusual_devs.h~	2008-07-13 18:51:29.000000000 -0300
+++ linux-2.6/drivers/usb/storage/unusual_devs.h	2008-10-07 23:38:38.000000000 -0300
@@ -1694,6 +1694,15 @@
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_IGNORE_RESIDUE ),
 
+/* Reported by Alexandre Oliva <oliva@lsd.ic.unicamp.br>
+ * JMicron responds to USN and several other SCSI ioctls with a
+ * residue that causes subsequent I/O requests to fail.  */
+UNUSUAL_DEV(  0x152d, 0x2329, 0x0000, 0x9999,
+	        "JMicron",
+	        "USB to ATA/ATAPI Bridge",
+	        US_SC_DEVICE, US_PR_DEVICE, NULL,
+	        US_FL_IGNORE_RESIDUE ),
+
 /* Reported by Robert Schedel <r.schedel@yahoo.de>
  * Note: this is a 'super top' device like the above 14cd/6600 device */
 UNUSUAL_DEV(  0x1652, 0x6600, 0x0201, 0x0201,

[-- Attachment #3: Type: text/plain, Size: 257 bytes --]


-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}
FSFLA Board Member       ¡Sé Libre! => http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}