From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756070AbYJPKcP (ORCPT ); Thu, 16 Oct 2008 06:32:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753342AbYJPKcA (ORCPT ); Thu, 16 Oct 2008 06:32:00 -0400 Received: from terminus.zytor.com ([198.137.202.10]:35099 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbYJPKb7 (ORCPT ); Thu, 16 Oct 2008 06:31:59 -0400 Message-ID: <48F717F6.10804@zytor.com> Date: Thu, 16 Oct 2008 03:31:18 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Linus Torvalds CC: Ingo Molnar , Alan Cox , Jiri Slaby , Linux Kernel Mailing List , linux-mm@kvack.org, "David S. Miller" , the arch/x86 maintainers Subject: Re: GIT head no longer boots on x86-64 References: <1223910693-28693-1-git-send-email-jirislaby@gmail.com> <20081013164717.7a21084a@lxorguk.ukuu.org.uk> <20081015115153.GA16413@elte.hu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > Oh, btw. This patch is *totally* untested. I don't even enable modules. So > if it doesn't compile, it isn't perfect. But while it may not _work_, at > least it's not _ugly_. > > (Quite frankly, I think an even more correct fix is to rename the whole > "vmalloc_to_page()" function, since it's clearly used for other things > than vmalloc. Maybe "kernel_virtual_to_page()". Whatever. This is trying > to be minimal without being totally disgusting). > I have verified that this patch fixes the problem, at least in my test rig, and has queued it up for tip:x86/urgent. It should be in the next pull request. Note that this bug only bites when CONFIG_DEBUG_VIRTUAL=y and we're running an SMP kernel on UP. Not that that is any excuse. -hpa