From: Brice Goglin <Brice.Goglin@inria.fr>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Nathalie Furmento <nathalie.furmento@labri.fr>
Subject: Re: [PATCH 4/5] mm: rework do_pages_move() to work on page_sized chunks
Date: Thu, 16 Oct 2008 23:18:24 +0200 [thread overview]
Message-ID: <48F7AFA0.1080100@inria.fr> (raw)
In-Reply-To: <48F79B42.3070106@linux-foundation.org>
Christoph Lameter wrote:
>> + err = -ENOMEM;
>> + pm = kmalloc(PAGE_SIZE, GFP_KERNEL);
>> + if (!pm)
>>
>
> ok.... But if you need a page sized chunk then you can also do
> get_zeroed_page(GFP_KERNEL). Why bother the slab allocator for page sized
> allocations?
>
Right. But why get_zeroed_page()? I don't think I need anything zeroed
(and I needed so, I would have to zero again between each chunk).
alloc_pages(order=0)+__free_pages() is probably good.
>> + /* fill the chunk pm with addrs and nodes from user-space */
>> + for (j = 0; j < chunk_nr_pages; j++) {
>>
>
> j? So the chunk_start used to be i?
>
The original "i" is somehow "chunk_start+j" now.
Thanks Christoph, I'll send an updated "4/5" patch in the next days.
Brice
next prev parent reply other threads:[~2008-10-16 21:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 20:19 [PATCH 0/5] mm: rework sys_move_pages() to avoid vmalloc and reduce the overhead Brice Goglin
2008-10-13 20:21 ` [PATCH 1/5] mm: stop returning -ENOENT from sys_move_pages() if nothing got migrated Brice Goglin
2008-10-16 19:34 ` Christoph Lameter
2008-10-13 20:21 ` [PATCH 2/5] mm: don't vmalloc a huge page_to_node array for do_pages_stat() Brice Goglin
2008-10-16 19:39 ` Christoph Lameter
2008-10-13 20:22 ` [PATCH 3/5] mm: extract do_pages_move() out of sys_move_pages() Brice Goglin
2008-10-16 19:40 ` Christoph Lameter
2008-10-13 20:22 ` [PATCH 4/5] mm: rework do_pages_move() to work on page_sized chunks Brice Goglin
2008-10-16 19:51 ` Christoph Lameter
2008-10-16 21:18 ` Brice Goglin [this message]
2008-10-17 11:35 ` [RESEND][PATCH] " Brice Goglin
2008-10-17 13:10 ` Christoph Lameter
2008-10-13 20:23 ` [PATCH 5/5] mm: move_pages: no need to set pp->page to ZERO_PAGE(0) by default Brice Goglin
2008-10-16 19:42 ` Christoph Lameter
2008-10-14 20:53 ` [PATCH 0/5] mm: rework sys_move_pages() to avoid vmalloc and reduce the overhead Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F7AFA0.1080100@inria.fr \
--to=brice.goglin@inria.fr \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nathalie.furmento@labri.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox