public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alexander E. Patrakov" <patrakov@gmail.com>
To: Jeremy Huntwork <jhuntwork@lightcubesolutions.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: headers_install broken on early versions of perl
Date: Fri, 17 Oct 2008 10:13:39 +0600	[thread overview]
Message-ID: <48F810F3.8080409@gmail.com> (raw)
In-Reply-To: <EA1CEB12-7E00-4939-AFA9-84B865E185B4@lightcubesolutions.com>

Jeremy Huntwork wrote:
> Hello,
> 
> This may not be a very large concern, but the new headers_install.pl and 
> headers_check.pl scripts do not work with versions of Perl < 5.6.0. This 
> is largely to do with syntax changes in that version. Previously, open() 
> only allowed two arguments. The following patch (against 2.6.27.1) 
> alters the syntax to be backwards compatible with earlier versions. It 
> has been tested on 5.005_03, and 5.8.8.
> 
> Please CC me on any comments as I am not subscribed to this list.
> 
> Thanks,
> 
> Jeremy Huntwork
> 
> 
> diff -Naur linux-2.6.27.1.orig/scripts/headers_check.pl 
> linux-2.6.27.1/scripts/headers_check.pl
> --- linux-2.6.27.1.orig/scripts/headers_check.pl        Wed Oct 15 
> 19:02:53 2008
> +++ linux-2.6.27.1/scripts/headers_check.pl     Thu Oct 16 19:10:37 2008

There is no Signed-off-by: header in your mail, this is a formal reason 
for rejection. Please read Documentation/SubmittingPatches and retry.

-- 
Alexander E. Patrakov

      reply	other threads:[~2008-10-17  4:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17  3:36 headers_install broken on early versions of perl Jeremy Huntwork
2008-10-17  4:13 ` Alexander E. Patrakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F810F3.8080409@gmail.com \
    --to=patrakov@gmail.com \
    --cc=jhuntwork@lightcubesolutions.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox