From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86/proc: fix /proc/cpuinfo cpu offline bug
Date: Fri, 17 Oct 2008 16:55:25 +0800 [thread overview]
Message-ID: <48F852FD.7070108@cn.fujitsu.com> (raw)
In my test, I found that if a cpu has been offline,
the next cpus may not be shown in the /proc/cpuinfo.
trivially reproduce this bug:
1) add these lines in the end of show_cpuinfo()
if (m->size - m->count - 20 > 0)
seq_printf(m, "%*s", (int)(m->size - m->count - 20), "show bug\n");
2) rebuilt kernel & reboot
3) offline cpu#1
4) cat /proc/cpuinfo
cpu#2 and cpu#3 .... cannot be shown in /proc/cpuinfo
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
index a26c480..01b1244 100644
--- a/arch/x86/kernel/cpu/proc.c
+++ b/arch/x86/kernel/cpu/proc.c
@@ -160,14 +160,16 @@ static void *c_start(struct seq_file *m, loff_t *pos)
{
if (*pos == 0) /* just in case, cpu 0 is not the first */
*pos = first_cpu(cpu_online_map);
- if ((*pos) < nr_cpu_ids && cpu_online(*pos))
+ else
+ *pos = next_cpu_nr(*pos - 1, cpu_online_map);
+ if ((*pos) < nr_cpu_ids)
return &cpu_data(*pos);
return NULL;
}
static void *c_next(struct seq_file *m, void *v, loff_t *pos)
{
- *pos = next_cpu(*pos, cpu_online_map);
+ (*pos)++;
return c_start(m, pos);
}
next reply other threads:[~2008-10-17 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 8:55 Lai Jiangshan [this message]
2008-10-17 11:41 ` [PATCH] x86/proc: fix /proc/cpuinfo cpu offline bug Alexey Dobriyan
2008-10-17 12:44 ` Lai Jiangshan
2008-10-22 4:39 ` Lai Jiangshan
2008-10-22 4:42 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F852FD.7070108@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox